front: rename and refacto StdcmInputVia #10218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarani
requested review from
SarahBellaha,
SharglutDev and
Yohh
and removed request for
SarahBellaha
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10218 +/- ##
==========================================
- Coverage 81.63% 81.62% -0.02%
==========================================
Files 1063 1063
Lines 105426 105431 +5
Branches 722 722
==========================================
- Hits 86063 86055 -8
- Misses 19322 19335 +13
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
clarani
force-pushed
the
cni/refacto-stdcm-input-via
branch
from
d400c63 to
5112724
Compare
Math-R
reviewed
Jan 6, 2025
front/src/applications/stdcm/components/StdcmForm/StopDurationInput.tsx
Outdated
Show resolved
Hide resolved
Math-R
reviewed
Jan 6, 2025
front/src/applications/stdcm/components/StdcmForm/StopDurationInput.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Clara Ni <[email protected]>
- use useDebounce hook instead of custom debounce function - add a useEffect to update the store when the input is changed - move the callback function inside the component stopDurationInput Signed-off-by: Clara Ni <[email protected]>
clarani
force-pushed
the
cni/refacto-stdcm-input-via
branch
from
0d5b248 to
a164cda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.