github: group osrd-ui dependabot upgrades #10225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osrd-ui has an unusual versioning scheme: it uses 0.0.x and all releases may contain breaking changes. Signed-off-by: Simon Ser <[email protected]>
github-actions
bot
added
the
area:ci
|
This still allows dependabot to bump osrd-ui ? I'm afraid some "ghost" changes which doesn't break the CI - like one in v0.0.58 - might be forgotten. Or should we still allow it and be more rigorous for these kind of changes (like always creating a separated issue from the bump) ? |
|
dependabot will create a separate PR with all osrd-ui upgrades. Then it's up to the reviewer to check the changelog and make sure the breaking changes are all accounted for. I don't think there's anything really osrd-ui-specific here, any dependency upgrade can pass CI and still break stuff :P |
SharglutDev
approved these changes
Jan 3, 2025
|
It's kind of an edge case anyway as most of the time we bump |
Khoyo
approved these changes
Jan 6, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
osrd-ui has an unusual versioning scheme: it uses 0.0.x and all releases may contain breaking changes.