Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: remove map feature from simulation report sheet #10237

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

achrafmohye
Copy link
Contributor

No description provided.

@achrafmohye achrafmohye requested a review from a team as a code owner January 6, 2025 10:20
@achrafmohye achrafmohye requested a review from Akctarus January 6, 2025 10:20
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 6, 2025
@achrafmohye achrafmohye requested a review from clarani January 6, 2025 10:20
@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.44%. Comparing base (2d1a142) to head (dfd9626).
Report is 42 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10237      +/-   ##
==========================================
+ Coverage   81.42%   81.44%   +0.02%     
==========================================
  Files        1057     1058       +1     
  Lines      104204   104222      +18     
  Branches      720      722       +2     
==========================================
+ Hits        84849    84885      +36     
+ Misses      19313    19296      -17     
+ Partials       42       41       -1     
Flag Coverage Δ
editoast 73.56% <ø> (-0.01%) ⬇️
front 89.21% <100.00%> (+0.03%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to remove one of the 2 lines at the bottom of the file
image

@achrafmohye achrafmohye force-pushed the ame/remove-map-from-simualtion-report-sheet branch from fcb4164 to 63be9e1 Compare January 6, 2025 16:44
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@clarani clarani changed the title Remove map feature from simualtion report sheet Remove map feature from simulation report sheet Jan 7, 2025
@clarani clarani changed the title Remove map feature from simulation report sheet front: remove map feature from simulation report sheet Jan 7, 2025
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you squash your commits ?

@achrafmohye achrafmohye force-pushed the ame/remove-map-from-simualtion-report-sheet branch from 63be9e1 to dfd9626 Compare January 7, 2025 10:46
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@achrafmohye achrafmohye enabled auto-merge January 7, 2025 11:07
@achrafmohye achrafmohye added this pull request to the merge queue Jan 7, 2025
Merged via the queue into dev with commit 382d08d Jan 7, 2025
27 checks passed
@achrafmohye achrafmohye deleted the ame/remove-map-from-simualtion-report-sheet branch January 7, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants