-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editoast: filter train schedules for LMR #10347
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10347 +/- ##
==========================================
- Coverage 81.65% 81.62% -0.04%
==========================================
Files 1066 1066
Lines 105692 105736 +44
Branches 727 727
==========================================
- Hits 86304 86302 -2
- Misses 19347 19393 +46
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c3b441e
to
fc93802
Compare
fc93802
to
1638183
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A few questions:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes and the explications on call!
b5a6e2a
to
2fd6bc7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2fd6bc7
to
490db3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the explanation, it really helps understand what's going on :)
Signed-off-by: Youness CHRIFI ALAOUI <[email protected]>
490db3f
to
47be88a
Compare
Part of this issue