Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: filter train schedules for LMR #10347

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

younesschrifi
Copy link
Contributor

@younesschrifi younesschrifi commented Jan 13, 2025

Part of this issue

@github-actions github-actions bot added the area:editoast Work on Editoast Service label Jan 13, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 47.61905% with 22 lines in your changes missing coverage. Please review.

Project coverage is 81.62%. Comparing base (76f971d) to head (47be88a).
Report is 7 commits behind head on dev.

Files with missing lines Patch % Lines
editoast/src/views/timetable/stdcm.rs 24.00% 19 Missing ⚠️
editoast/src/models/timetable.rs 82.35% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10347      +/-   ##
==========================================
- Coverage   81.65%   81.62%   -0.04%     
==========================================
  Files        1066     1066              
  Lines      105692   105736      +44     
  Branches      727      727              
==========================================
- Hits        86304    86302       -2     
- Misses      19347    19393      +46     
  Partials       41       41              
Flag Coverage Δ
editoast 73.59% <47.61%> (-0.12%) ⬇️
front 89.33% <ø> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@younesschrifi younesschrifi force-pushed the yci/filter-train-simulation branch 2 times, most recently from c3b441e to fc93802 Compare January 13, 2025 23:33
@younesschrifi younesschrifi marked this pull request as ready for review January 14, 2025 08:08
@younesschrifi younesschrifi requested a review from a team as a code owner January 14, 2025 08:08
@younesschrifi younesschrifi force-pushed the yci/filter-train-simulation branch from fc93802 to 1638183 Compare January 14, 2025 10:07
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few questions:

editoast/src/models/train_schedule.rs Outdated Show resolved Hide resolved
editoast/src/models/train_schedule.rs Outdated Show resolved Hide resolved
editoast/src/views/timetable/stdcm.rs Outdated Show resolved Hide resolved
editoast/src/views/timetable/stdcm.rs Outdated Show resolved Hide resolved
editoast/src/views/timetable/stdcm.rs Outdated Show resolved Hide resolved
editoast/src/views/timetable/stdcm.rs Outdated Show resolved Hide resolved
editoast/src/views/timetable/stdcm.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes and the explications on call!

editoast/src/models/timetable.rs Outdated Show resolved Hide resolved
editoast/src/models/timetable.rs Outdated Show resolved Hide resolved
editoast/src/views/timetable/stdcm.rs Outdated Show resolved Hide resolved
editoast/src/views/timetable/stdcm.rs Outdated Show resolved Hide resolved
@younesschrifi younesschrifi force-pushed the yci/filter-train-simulation branch 2 times, most recently from b5a6e2a to 2fd6bc7 Compare January 14, 2025 21:09
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@younesschrifi younesschrifi force-pushed the yci/filter-train-simulation branch from 2fd6bc7 to 490db3f Compare January 15, 2025 09:18
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the explanation, it really helps understand what's going on :)

Signed-off-by: Youness CHRIFI ALAOUI <[email protected]>
@younesschrifi younesschrifi force-pushed the yci/filter-train-simulation branch from 490db3f to 47be88a Compare January 15, 2025 09:27
@younesschrifi younesschrifi added this pull request to the merge queue Jan 15, 2025
Merged via the queue into dev with commit ed45fd3 Jan 15, 2025
27 checks passed
@younesschrifi younesschrifi deleted the yci/filter-train-simulation branch January 15, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants