front: do not persist STDCM configuration #10381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tate Using localStorage here is a bit of a hack: we don't actually want to persist anything on disk. This also doesn't work when multiple STDCM tabs are opened: launch 2 simulations, go back to the first one, click the "Start a new query from the current one" button, and the state of the second tab gets restored. Instead, use a global variable to pass the form state to the new window. Signed-off-by: Simon Ser <[email protected]>
@thibautsailly has confirmed that restoring the STDCM form values wasn't desirable when opening a new STDCM window. Fixes crashes when reading an old local storage with data which doesn't conform to the new types. Signed-off-by: Simon Ser <[email protected]>
emersion
force-pushed
the
emr/stdcm-no-persist
branch
from
0930f88 to
a432361
Compare
Wadjetz
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@thibautsailly has confirmed that restoring the STDCM form values wasn't desirable when opening a new STDCM window.
Fixes crashes when reading an old local storage with data which doesn't conform to the new types.