editoast, front : fix step update erasing parts of the study in studies page

[Synar]

Close #6455

I believe the issue came from the fact editoast does not properly handles a partial studyForm, as the attributes are nullable and editoast does not seem to distinguish between an undefined attribute and a null one. The study changeset is indeed option<option>, but the studyForm is simply option. I am unsure if we can handle this better, considering the limitations of open api and type conversions between js and rust.

In the meantime, we now send the full study everytime.

Also fix a couple inconsistent translations in study dates

Edit : patches now properly handled in editoast thanks to serde with double option, we only send partial study patches again

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 96.77419% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.78%. Comparing base (ddc52f5) to head (071f721).
Report is 68 commits behind head on dev.

Files with missing lines	Patch %	Lines
editoast/src/views/projects.rs	83.33%	1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev   #10382      +/-   ##
==========================================
+ Coverage   81.65%   81.78%   +0.12%     
==========================================
  Files        1066     1073       +7     
  Lines      105692   106565     +873     
  Branches      727      731       +4     
==========================================
+ Hits        86302    87149     +847     
- Misses      19349    19377      +28     
+ Partials       41       39       -2     

Flag	Coverage Δ
editoast	74.21% <92.85%> (+0.51%)	⬆️
front	89.34% <100.00%> (+<0.01%)	⬆️
gateway	2.18% <ø> (ø)
osrdyne	3.28% <ø> (ø)
railjson_generator	87.50% <ø> (ø)
tests	87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[woshilapin]

Great improvement for editoast form's. We should actually bring that to other forms now that we know 😄.

I actually tested a PUT on /studies with {"description":"something"}, then with {"study_type":"something"} (checking that description has not been erased in the process) and it works well. Then finally with {"description":null} which works also as expected.

[hamz2a]

LGTM, thanks!

[leovalais]

We should actually bring that to other forms now that we know 😄

That's actually quite a lot of them 😨

I came to really dislike the flat_* functions of the changeset. I'd rather have something like MaybeUnset<T> which could also be used by API forms (much like what SeaORM does with it's ActiveRecords 👀). Anyway it has to be refined and it's for another PR, thanks for the fix!

[Yohh]

NIT: if I "missclick" on ended, then rollback to in progress the REAL END keeps a date

[Synar]

NIT: if I "missclick" on ended, then rollback to in progress the REAL END keeps a date

We could definitely set the real end date to null if the status is set to anything but ended, but I wanted to keep to the letter of the issue, which stated "The dates should not change, except the REAL END date that sould follow today's date when Status is set to Ended". I don't have a strong opinion on the subject though

[clarani]

LGTM & tested ✅

I'm ok with the current behaviour, but I don't have a strong opinon on this too