Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: stdcm: increase max length to test for engineering allowances #10386

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Jan 15, 2025

Fix #10385 (at least the few cases I've seen recently, I'll re-check if it still happens afterwards)

So apparently even 20km isn't always enough to add any amount of delay, because sometimes we barely have the traction to maintain the current speed. Ideally we should remove that check altogether, but it would still cause performance issues (repeatedly computing margins over potentially thousands of kilometers would certainly cause timeouts). We should look into #7136 for a proper solution.

EDIT: this version is better but it's still not enough. I've found a case with a 300km long allowance section that was still impossible. We may need to rework some stuff.


So there's two extra fixes:

  1. Small bugfix on how we compute the "slowest envelope": we'd stop early if the max speed envelope ended with a speedup (we'd "intersect" right away)
  2. In post-processing, prefill the fixed time point list with the end of every engineering allowance. This avoids some unnecessary and constraining extra fixed points at the wrong places.

@eckter eckter requested a review from Erashin January 15, 2025 09:26
@eckter eckter requested a review from a team as a code owner January 15, 2025 09:26
@github-actions github-actions bot added the area:core Work on Core Service label Jan 15, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.60%. Comparing base (9151b80) to head (dd1c45f).
Report is 16 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10386      +/-   ##
==========================================
- Coverage   81.62%   81.60%   -0.02%     
==========================================
  Files        1067     1067              
  Lines      105624   105624              
  Branches      727      727              
==========================================
- Hits        86216    86199      -17     
- Misses      19367    19384      +17     
  Partials       41       41              
Flag Coverage Δ
editoast 73.62% <ø> (-0.06%) ⬇️
front 89.32% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eckter eckter marked this pull request as draft January 15, 2025 14:31
@eckter eckter force-pushed the ech/fix-engineering-max-length branch from 21e4c3a to 18d2096 Compare January 15, 2025 15:42
@eckter eckter marked this pull request as ready for review January 15, 2025 15:45
@eckter eckter force-pushed the ech/fix-engineering-max-length branch 2 times, most recently from 7613b19 to 447dadf Compare January 16, 2025 10:20
@eckter eckter force-pushed the ech/fix-engineering-max-length branch 2 times, most recently from 24d2927 to 4be0cce Compare January 16, 2025 13:17
@eckter eckter force-pushed the ech/fix-engineering-max-length branch from 4be0cce to dd1c45f Compare January 16, 2025 13:32
Copy link
Contributor

@Erashin Erashin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@eckter eckter added this pull request to the merge queue Jan 16, 2025
Merged via the queue into dev with commit accd619 Jan 16, 2025
27 checks passed
@eckter eckter deleted the ech/fix-engineering-max-length branch January 16, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Work on Core Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core: stdcm: we're (still) too optimistic on engineering allowances
3 participants