Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: add version parameter to translations load path #10434

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

emersion
Copy link
Member

@emersion emersion commented Jan 17, 2025

That way, every time we release a new OSRD version, we force browsers to refresh translation files. This is similar to the hash inserted in JS/CSS filenames by vite.

Docs: https://github.com/i18next/i18next-xhr-backend?tab=readme-ov-file#backend-options

Closes: #9965

That way, every time we release a new OSRD version, we force
browsers to refresh translation files. This is similar to the hash
inserted in JS/CSS filenames by vite.

Signed-off-by: Simon Ser <[email protected]>
Closes: #9965
@emersion emersion requested a review from a team as a code owner January 17, 2025 16:55
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 17, 2025
Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job !

@emersion emersion self-assigned this Jan 20, 2025
Copy link
Contributor

@RomainValls RomainValls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emersion emersion added this pull request to the merge queue Jan 21, 2025
Merged via the queue into dev with commit 2950b2f Jan 21, 2025
27 checks passed
@emersion emersion deleted the emr/translations-version-param branch January 21, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Traductions not loading
3 participants