Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: stdcm: add fixed time points at start+end of engineering allowances #10488

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Jan 22, 2025

Fix what I believe to be the last cases of #10412

Though while investigating I found this, when printing the engineering allowances on the final path:

...
margin from 234,337m to 444,837m
margin from 234,337m to 446,622m
margin from 116,065m to 449,152m
margin from 234,337m to 451,259m
...

Meaning: a margin went further back than the previous margin. It doesn't seem to cause any significant issue yet, but it feels very wrong and worth looking into.

@eckter eckter requested a review from Erashin January 22, 2025 15:34
@eckter eckter requested a review from a team as a code owner January 22, 2025 15:34
@github-actions github-actions bot added the area:core Work on Core Service label Jan 22, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.80%. Comparing base (60a43d5) to head (e589498).
Report is 11 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10488      +/-   ##
==========================================
+ Coverage   81.78%   81.80%   +0.01%     
==========================================
  Files        1073     1073              
  Lines      106578   106584       +6     
  Branches      731      731              
==========================================
+ Hits        87164    87188      +24     
+ Misses      19375    19357      -18     
  Partials       39       39              
Flag Coverage Δ
editoast 74.28% <ø> (+0.06%) ⬆️
front 89.34% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Erashin Erashin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Distance bug is probably caused by a length computation bug, which was never really apparent until now. As discussed, it's fine to merge this rn, and you'll look into it later on.

@eckter eckter added this pull request to the merge queue Jan 23, 2025
Merged via the queue into dev with commit f0a5c8e Jan 23, 2025
27 checks passed
@eckter eckter deleted the ech/fix-stdcm-first-points branch January 23, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Work on Core Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants