Fix incorrect input saving when switching simulations during a running calculation #10497
Conversation
kmer2016
requested review from
theocrsb,
SharglutDev and
RomainValls
and removed request for
theocrsb
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10497 +/- ##
=======================================
Coverage 81.94% 81.94%
=======================================
Files 1078 1078
Lines 107587 107664 +77
Branches 733 734 +1
=======================================
+ Hits 88158 88229 +71
- Misses 19390 19396 +6
Partials 39 39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kmer2016
force-pushed
the
cnh/front/fix-wrong-inputs-saved
branch
from
cf10bc1 to
d4cca27
Compare
There was a problem hiding this comment.
If I switch between simulations, it seems like the speed limit tag isn't reset
There was a problem hiding this comment.
Seems like this bug is still there ?
There was a problem hiding this comment.
I can't reproduce the bug
Capture vidéo du 10-02-2025 18:13:25.webm
There was a problem hiding this comment.
If I switch between a simulation with a short form and a long one, the viewport changes. I think it should stay as it is when we switch (you can double check with @thibautsailly). Also maybe we should remove the animation for the via in that case, it's a little weird.
https://github.com/user-attachments/assets/0fbadb77-d587-40b3-bd5b-58f828ffeae5
There was a problem hiding this comment.
The last part of the comment is fixed but the first part
I think it should stay as it is when we switch
is still there. What did @thibautsailly said about that ?
There was a problem hiding this comment.
confirmed by @thibautsailly
kmer2016
force-pushed
the
cnh/front/fix-wrong-inputs-saved
branch
from
d4cca27 to
8016bc4
Compare
kmer2016
force-pushed
the
cnh/front/fix-wrong-inputs-saved
branch
3 times, most recently
from
aeaf7ba to
495a832
Compare
| @@ -107,7 +107,10 @@ | |||
| } | |||
|
|
|||
| .stdcm-vias-bundle { | |||
| animation: bouncin-in 0.75s cubic-bezier(0.567, -0.475, 0, 1); | |||
|
|
|||
| &.animated { | |||
There was a problem hiding this comment.
With this behavior, we have the animation after switching simulation and clearing a via input
Enregistrement.de.l.ecran.2025-02-06.a.12.50.40.mov
There was a problem hiding this comment.
The last part of the comment is fixed but the first part
I think it should stay as it is when we switch
is still there. What did @thibautsailly said about that ?
kmer2016
force-pushed
the
cnh/front/fix-wrong-inputs-saved
branch
2 times, most recently
from
fd06672 to
fba5713
Compare
… running calculation When a different simulation is selected while a calculation is still running, the new simulation’s inputs overwrite the inputs of the ongoing calculation. This causes a mismatch between the inputs used for the calculation and the results. Now, the inputs for the simulation being calculated are stored in a different state variable than the one used for the selected simulation. Signed-off-by: nncluzu <[email protected]>
…rent simulation Signed-off-by: nncluzu <[email protected]>
Signed-off-by: nncluzu <[email protected]>
Signed-off-by: nncluzu <[email protected]>
Signed-off-by: nncluzu <[email protected]>
…a input Signed-off-by: nncluzu <[email protected]>
kmer2016
force-pushed
the
cnh/front/fix-wrong-inputs-saved
branch
from
fba5713 to
3b7c890
Compare
closes #10480
When a different simulation is selected while a calculation is still running, the new simulation’s inputs overwrite the inputs of the ongoing calculation. This causes a mismatch between the inputs used for the calculation and the results.
Now, the inputs for the simulation being calculated are stored in a different state variable than the one used for the selected simulation.