-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: fix path step not updated in debug mode #10499
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10499 +/- ##
==========================================
- Coverage 81.80% 81.80% -0.01%
==========================================
Files 1073 1073
Lines 106606 106712 +106
Branches 731 730 -1
==========================================
+ Hits 87214 87299 +85
- Misses 19353 19374 +21
Partials 39 39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hm, that sounds a bit weird… So Are we missing something from the check? Should we compare other values? |
Signed-off-by: nncluzu <[email protected]>
ab7986f
to
48be85a
Compare
Yes, it may seem strange, but it's intended for debug mode. We want users to be able to rerun the simulation with the same inputs to simplify troubleshooting. This doesn’t affect non-debug mode, which checks inputs to avoid unnecessary reruns. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
closes #10337