Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix path step not updated in debug mode #10499

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

kmer2016
Copy link
Contributor

closes #10337

@kmer2016 kmer2016 requested a review from a team as a code owner January 23, 2025 10:47
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Jan 23, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.80%. Comparing base (23a21ce) to head (48be85a).
Report is 88 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10499      +/-   ##
==========================================
- Coverage   81.80%   81.80%   -0.01%     
==========================================
  Files        1073     1073              
  Lines      106606   106712     +106     
  Branches      731      730       -1     
==========================================
+ Hits        87214    87299      +85     
- Misses      19353    19374      +21     
  Partials       39       39              
Flag Coverage Δ
editoast 74.29% <ø> (-0.02%) ⬇️
front 89.34% <100.00%> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emersion
Copy link
Member

Hm, that sounds a bit weird… So currentSimulationInputs is equal to the previous one but something changed?

Are we missing something from the check? Should we compare other values?

@kmer2016 kmer2016 force-pushed the cnh/front/fix-stdcm-path-step-not-updated branch from ab7986f to 48be85a Compare January 23, 2025 16:42
@kmer2016
Copy link
Contributor Author

Hm, that sounds a bit weird… So currentSimulationInputs is equal to the previous one but something changed?

Are we missing something from the check? Should we compare other values?

Yes, it may seem strange, but it's intended for debug mode. We want users to be able to rerun the simulation with the same inputs to simplify troubleshooting. This doesn’t affect non-debug mode, which checks inputs to avoid unnecessary reruns.

Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kmer2016 kmer2016 added this pull request to the merge queue Feb 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 4, 2025
@kmer2016 kmer2016 added this pull request to the merge queue Feb 4, 2025
Merged via the queue into dev with commit b6980e8 Feb 4, 2025
27 checks passed
@kmer2016 kmer2016 deleted the cnh/front/fix-stdcm-path-step-not-updated branch February 4, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: !debug mode only! stdcm path step are not updated when modifying date input
4 participants