core: pathfinding: fix missing waypoints in edge cases

[eckter]

Fix a pathfinding regression, we'd "pass" the waypoints without adding them to the result

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.82%. Comparing base (9314f35) to head (f8226ab).
Report is 1 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev   #10533      +/-   ##
==========================================
- Coverage   81.82%   81.82%   -0.01%     
==========================================
  Files        1073     1073              
  Lines      106829   106829              
  Branches      730      730              
==========================================
- Hits        87413    87409       -4     
- Misses      19377    19381       +4     
  Partials       39       39              

Flag	Coverage Δ
editoast	74.28% <ø> (-0.02%)	⬇️
front	89.34% <ø> (ø)
gateway	2.18% <ø> (ø)
osrdyne	3.28% <ø> (ø)
railjson_generator	87.50% <ø> (ø)
tests	88.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[JulesPeignier]

Thanks a lot

[Erashin]

Agreed, this class has become hard to deal with. Anyway, gj.

[Khoyo]

Nice catch