Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: fix some nightly clippy warnings #10556

Merged
merged 1 commit into from
Jan 28, 2025
Merged

editoast: fix some nightly clippy warnings #10556

merged 1 commit into from
Jan 28, 2025

Conversation

leovalais
Copy link
Contributor

@leovalais leovalais commented Jan 28, 2025

warning: useless conversion to the same type: `WorkerStatus`
   --> editoast_osrdyne_client/src/lib.rs:163:30
    |
163 |                        .copied()
    |   ______________________________^
    |  |______________________________|
164 | ||                     .map(WorkerStatus::from)
    | ||____________________________________________^
165 | |                      .unwrap_or(WorkerStatus::Unscheduled);
    | |_____________________- help: consider removing
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
    = note: `#[warn(clippy::useless_conversion)]` on by default

warning: useless conversion to the same type: `models::timetable::Timetable`
  --> src/models/timetable.rs:46:19
   |
46 |                .await
   |   ___________________^
   |  |___________________|
47 | ||             .map(Into::into)
   | ||____________________________^
48 | |              .map_err(Into::into)
   | |_____________- help: consider removing
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
   = note: `#[warn(clippy::useless_conversion)]` on by default

warning: useless conversion to the same type: `error::InternalError`
   --> src/models/timetable.rs:135:34
    |
135 |                .map(|r| r.is_some())
    |   __________________________________^
    |  |__________________________________|
136 | ||             .map_err(Into::into)
    | ||________________________________^
137 | |      }
    | |_____- help: consider removing
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

@leovalais leovalais requested a review from a team as a code owner January 28, 2025 15:08
@github-actions github-actions bot added the area:editoast Work on Editoast Service label Jan 28, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.87%. Comparing base (f2b3f8b) to head (2643600).
Report is 4 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10556      +/-   ##
==========================================
- Coverage   81.87%   81.87%   -0.01%     
==========================================
  Files        1073     1073              
  Lines      107106   107102       -4     
  Branches      730      730              
==========================================
- Hits        87690    87686       -4     
  Misses      19377    19377              
  Partials       39       39              
Flag Coverage Δ
editoast 74.29% <100.00%> (-0.01%) ⬇️
front 89.39% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 88.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leovalais leovalais added this pull request to the merge queue Jan 28, 2025
Merged via the queue into dev with commit 0ff5cac Jan 28, 2025
27 checks passed
@leovalais leovalais deleted the lva/clippy branch January 28, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants