front: remove react-beautiful-dnd #10617
Conversation
The lib hasn't been updated since 2022 and now is outdated regarding React 19 new version. The lib uses React "defaultProps" feature which is deprecated in React 19. As the drag and drop feature isn't used by users and can be bypassed, remove the lib and the related feature to enable a future migration to React 19. Signed-off-by: SharglutDev <[email protected]>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10617 +/- ##
==========================================
- Coverage 81.85% 81.82% -0.03%
==========================================
Files 1075 1073 -2
Lines 107153 107015 -138
Branches 728 722 -6
==========================================
- Hits 87708 87564 -144
- Misses 19406 19412 +6
Partials 39 39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Worth noting that the authors of beautiful dnd have created a new lib called pragmatic dnd, which they recommend in their deprecation announcement for beautiful dnd. If we're only removing the feature for react 19 support, it may be worth migrating instead |
Yes you're right, I saw that as well. As I tried to explain, this lib was used only for the drag and drop feature which wasn't used by our users. Ex: I have a path Perrigny - Valence - Avignon - Miramas, if I switch Valence and Avignon, the pathfinding breaks, it doesn't make any sense geographically. It will be pretty rare to have a proper use of this feature. Even if it's not a big deal to migrate with the new lib, @thibautsailly validated that we don't really need the feature and we shouldn't devote time for that. |
The lib hasn't been updated since 2022 and now is outdated regarding React 19 new version. The lib uses React "defaultProps" feature which is deprecated in React 19. As the drag and drop feature isn't used by users and can be bypassed, remove the lib and the related feature to enable a future migration to React 19.
close #10616