Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: stdcm: reduce visited margin #10674

Merged
merged 1 commit into from
Feb 4, 2025
Merged

core: stdcm: reduce visited margin #10674

merged 1 commit into from
Feb 4, 2025

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Feb 4, 2025

The value was too large for takeovers with fast trains, we'd "miss" an opening and let two trains pass instead of one.

This will have a performance cost, but there isn't any way around it. We were likely missing a few solutions in edge cases before.

The value was too large for takeovers with fast trains.

Signed-off-by: Eloi Charpentier <[email protected]>
@eckter eckter requested a review from a team as a code owner February 4, 2025 14:27
@eckter eckter requested a review from Khoyo February 4, 2025 14:27
@github-actions github-actions bot added the area:core Work on Core Service label Feb 4, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.88%. Comparing base (ecb261f) to head (be9dc06).
Report is 50 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10674      +/-   ##
==========================================
+ Coverage   81.85%   81.88%   +0.02%     
==========================================
  Files        1075     1078       +3     
  Lines      107172   107145      -27     
  Branches      728      724       -4     
==========================================
+ Hits        87726    87732       +6     
+ Misses      19407    19373      -34     
- Partials       39       40       +1     
Flag Coverage Δ
editoast 74.16% <ø> (-0.08%) ⬇️
front 89.45% <ø> (+0.06%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 88.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eckter eckter added this pull request to the merge queue Feb 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 4, 2025
@eckter eckter added this pull request to the merge queue Feb 4, 2025
Merged via the queue into dev with commit 005ff04 Feb 4, 2025
27 checks passed
@eckter eckter deleted the ech/reduce-visited-margin branch February 4, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Work on Core Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants