-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: editor: make LPV editable #4040
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #4040 +/- ##
============================================
- Coverage 20.27% 20.00% -0.27%
Complexity 2080 2080
============================================
Files 799 805 +6
Lines 78795 79834 +1039
Branches 2070 2078 +8
============================================
+ Hits 15972 15973 +1
- Misses 61651 62681 +1030
- Partials 1172 1180 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
SharglutDev
force-pushed
the
pfn/front/infra-edit-lpv
branch
from
May 10, 2023 14:46
12fde62
to
dbc2f66
Compare
clarani
commented
May 10, 2023
front/src/applications/editor/tools/speedSectionEdition/components.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/editor/tools/speedSectionEdition/components.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/editor/tools/speedSectionEdition/components.tsx
Outdated
Show resolved
Hide resolved
clarani
commented
May 11, 2023
front/src/applications/editor/tools/speedSectionEdition/components/LpvPanelCard.tsx
Outdated
Show resolved
Hide resolved
jacomyal
reviewed
May 11, 2023
jacomyal
approved these changes
May 11, 2023
clarani
force-pushed
the
pfn/front/infra-edit-lpv
branch
from
May 11, 2023 09:35
355988f
to
769ae51
Compare
jacomyal
approved these changes
May 11, 2023
clarani
force-pushed
the
pfn/front/infra-edit-lpv
branch
from
May 11, 2023 10:26
769ae51
to
ba5d1ca
Compare
younesschrifi
pushed a commit
that referenced
this pull request
May 17, 2023
closes #4008 --------- Co-authored-by: SharglutDev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4008