Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editoast: fix infra import order to cache (search) signals correctly #4403

Merged
merged 1 commit into from
Jun 21, 2023
Merged

editoast: fix infra import order to cache (search) signals correctly #4403

merged 1 commit into from
Jun 21, 2023

Conversation

leovalais
Copy link
Contributor

closes #3887

@leovalais leovalais added the area:editoast Work on Editoast Service label Jun 21, 2023
@leovalais leovalais requested a review from a team as a code owner June 21, 2023 09:26
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #4403 (5ed259c) into dev (1bc21af) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                dev    #4403      +/-   ##
============================================
+ Coverage     22.29%   22.31%   +0.01%     
  Complexity     2256     2256              
============================================
  Files           850      850              
  Lines         84086    84099      +13     
  Branches       2215     2215              
============================================
+ Hits          18749    18764      +15     
+ Misses        64124    64122       -2     
  Partials       1213     1213
Flag Coverage Δ
editoast 69.72% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
editoast/src/main.rs 9.14% <100.00%> (+0.52%) ⬆️
editoast/src/models/infra.rs 85.71% <100.00%> (+2.38%) ⬆️

... and 2 files with indirect coverage changes

flomonster
flomonster approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leovalais leovalais added this pull request to the merge queue Jun 21, 2023
younesschrifi
younesschrifi approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@younesschrifi younesschrifi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Merged via the queue into dev with commit bdf9ba8 Jun 21, 2023
@leovalais leovalais deleted the lva/fix-signal-caching-at-infra-import branch June 21, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@younesschrifi younesschrifi younesschrifi approved these changes

@flomonster flomonster flomonster approved these changes

@Castavo Castavo Awaiting requested review from Castavo

Assignees
No one assigned
Labels
area:editoast Work on Editoast Service
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

editoast: signals are not cached for search during import
3 participants
@leovalais @flomonster @younesschrifi