Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editoast: Add ROOT_PATH support #4636

Merged
merged 1 commit into from
Jul 21, 2023
Merged

editoast: Add ROOT_PATH support #4636

merged 1 commit into from
Jul 21, 2023

Conversation

bloussou
Copy link
Contributor

Needed to have the same as api ROOT_PATH parameter in order to have a clean deployment in the SNCF SI.

@bloussou bloussou added the area:editoast Work on Editoast Service label Jul 21, 2023
@bloussou bloussou self-assigned this Jul 21, 2023
@bloussou bloussou requested a review from a team as a code owner July 21, 2023 10:14
multun
multun reviewed Jul 21, 2023
View reviewed changes
editoast/src/main.rs Outdated Show resolved Hide resolved
@bloussou bloussou force-pushed the bln/AddRootPathSupportToEditoast branch from 17fcc45 to 6c8f729 Compare July 21, 2023 10:22
@bloussou bloussou requested a review from multun July 21, 2023 10:22
@codecov
Copy link

codecov bot commented Jul 21, 2023 •
edited
Loading

Codecov Report

Merging #4636 (17fcc45) into dev (86368db) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 17fcc45 differs from pull request most recent head 6c8f729. Consider uploading reports for the commit 6c8f729 to get more accurate results

@@            Coverage Diff            @@
##                dev    #4636   +/-   ##
=========================================
  Coverage     19.93%   19.94%           
  Complexity     2323     2323           
=========================================
  Files           865      865           
  Lines         88182    88184    +2     
  Branches       2280     2280           
=========================================
+ Hits          17583    17584    +1     
- Misses        69341    69342    +1     
  Partials       1258     1258
Flag Coverage Δ
editoast 61.20% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
editoast/src/client/mod.rs 33.33% <ø> (ø)
editoast/src/main.rs 36.84% <ø> (ø)

... and 2 files with indirect coverage changes

younesschrifi
younesschrifi approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@younesschrifi younesschrifi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@multun multun merged commit 40bf51c into dev Jul 21, 2023
@multun multun deleted the bln/AddRootPathSupportToEditoast branch July 21, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@younesschrifi younesschrifi younesschrifi approved these changes

@multun multun multun approved these changes

@Tguisnet Tguisnet Awaiting requested review from Tguisnet

Assignees

@bloussou bloussou

Labels
area:editoast Work on Editoast Service
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bloussou @multun @younesschrifi