Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: fix SwitchSNCF #4725

Merged
merged 1 commit into from
Aug 9, 2023
Merged

front: fix SwitchSNCF #4725

merged 1 commit into from
Aug 9, 2023

Conversation

Akctarus
Copy link
Contributor

@Akctarus Akctarus commented Aug 2, 2023

Close #4706

@Akctarus Akctarus requested a review from a team as a code owner August 2, 2023 08:11
@codecov
Copy link

codecov bot commented Aug 2, 2023 •
edited
Loading

Codecov Report

Merging #4725 (da33f4d) into dev (afcdd1b) will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##                dev    #4725   +/-   ##
=========================================
  Coverage     20.04%   20.04%           
  Complexity     2238     2238           
=========================================
  Files           875      875           
  Lines         89346    89346           
  Branches       2298     2298           
=========================================
  Hits          17910    17910           
  Misses        70157    70157           
  Partials       1279     1279
Flag Coverage Δ
front 9.53% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...src/common/BootstrapSNCF/SwitchSNCF/SwitchSNCF.tsx 0.00% <0.00%> (ø)

SharglutDev
SharglutDev approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool fix :) Tested.

@Akctarus Akctarus force-pushed the tmn/switch-back-to-geographic branch from 4ae02ac to f7f5e4d Compare August 3, 2023 15:20
clarani
clarani approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice ! Tested ✔️

@Akctarus Akctarus added this pull request to the merge queue Aug 4, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 4, 2023
@Akctarus Akctarus force-pushed the tmn/switch-back-to-geographic branch from f7f5e4d to b9c7126 Compare August 7, 2023 08:06
@Akctarus Akctarus enabled auto-merge August 7, 2023 08:19
@Akctarus Akctarus disabled auto-merge August 7, 2023 08:25
@Akctarus Akctarus added this pull request to the merge queue Aug 8, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 8, 2023
@Akctarus Akctarus added this pull request to the merge queue Aug 8, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 8, 2023
@Akctarus Akctarus added this pull request to the merge queue Aug 8, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 8, 2023
@Akctarus Akctarus added this pull request to the merge queue Aug 9, 2023
@Akctarus Akctarus removed this pull request from the merge queue due to a manual request Aug 9, 2023
@Akctarus Akctarus force-pushed the tmn/switch-back-to-geographic branch from b9c7126 to da33f4d Compare August 9, 2023 07:33
@flomonster flomonster merged commit 0356298 into dev Aug 9, 2023
@flomonster flomonster deleted the tmn/switch-back-to-geographic branch August 9, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SharglutDev SharglutDev SharglutDev approved these changes

@clarani clarani clarani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot switch back from schematic to geographic
4 participants
@Akctarus @clarani @SharglutDev @flomonster