Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: remove obsolete signaling engine #4744

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Conversation

multun
Copy link
Contributor

@multun multun commented Aug 4, 2023

This code:

  • is not used anywhere: it was previously used to compute signal updates for standalone simulation. STDCM uses something else
  • does not do the right thing: it conflates routes and blocks
  • is an obstacle to current efforts: the tests for this module fail if we fix routes in the example infrastructure

@multun multun requested a review from a team as a code owner August 4, 2023 09:05
@multun multun enabled auto-merge August 4, 2023 09:06
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #4744 (3f4d4f8) into dev (f43b725) will decrease coverage by 0.21%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #4744      +/-   ##
============================================
- Coverage     20.30%   20.09%   -0.21%     
+ Complexity     2329     2234      -95     
============================================
  Files           876      870       -6     
  Lines         89096    88936     -160     
  Branches       2319     2292      -27     
============================================
- Hits          18091    17872     -219     
- Misses        69722    69790      +68     
+ Partials       1283     1274       -9     
Flag Coverage Δ
core 78.95% <ø> (-0.92%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

This code:
 - is not used anywhere: it was previously used to compute signal updates for standalone simulation. STDCM uses something else
 - does not do the right thing: it conflates routes and blocks
 - is an obstacle to current efforts: the tests for this module fail if we fix routes in the example infrastructure
@multun multun disabled auto-merge August 4, 2023 09:22
@multun multun force-pushed the remove-obsolete-sig-engine branch from 3f4d4f8 to c01bc2c Compare August 4, 2023 09:24
@multun multun merged commit 8d3f0bb into dev Aug 4, 2023
@multun multun deleted the remove-obsolete-sig-engine branch August 4, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants