-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editoast: switch to diesel_async #4809
Conversation
6fbee33
to
0a49c5c
Compare
8e89c7b
to
4aca00d
Compare
Codecov Report
@@ Coverage Diff @@
## dev #4809 +/- ##
============================================
- Coverage 21.85% 21.82% -0.04%
Complexity 2248 2248
============================================
Files 861 861
Lines 90167 90205 +38
Branches 2284 2284
============================================
- Hits 19710 19690 -20
- Misses 69196 69254 +58
Partials 1261 1261
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a huge amount of work! It's nice to have everything decluttered by those blocks :) Thanks a lot!
I've just read the code for now and left a few cosmetic suggestions.
I wish the async move { ... }.scope_boxed()
pattern could be avoided, too bad we can't use async closures. Maybe a macro to hide the boilerplate would work?
In any case, even of the CI says it's good, we'll have to thoroughly test the app to make sure there's no hidden panic or weird behaviors introduced. I'll do that next week (I'm not against some help with that @Tguisnet @flomonster 😛).
65adc51
to
3bf2d67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Reviewed and tested. All features seems to work.
Closes #4829