Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Panel to Sign and LPV to PSL #4810

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Rename Panel to Sign and LPV to PSL #4810

merged 2 commits into from
Oct 4, 2023

Conversation

Bubullzz
Copy link
Contributor

Also need a front to finish the rename in the front-end.

@Bubullzz Bubullzz linked an issue Aug 14, 2023 that may be closed by this pull request
Rename panel to sign and lpv to psl #4740
Closed
2 tasks
@codecov
Copy link

codecov bot commented Aug 14, 2023 •
edited
Loading

Codecov Report

Merging #4810 (f4ba93a) into dev (a168f93) will increase coverage by 0.00%.
Report is 1 commits behind head on dev.
The diff coverage is 2.46%.

@@            Coverage Diff            @@
##                dev    #4810   +/-   ##
=========================================
  Coverage     18.85%   18.86%           
  Complexity     2469     2469           
=========================================
  Files           860      860           
  Lines        104576   104568    -8     
  Branches       2512     2512           
=========================================
+ Hits          19723    19725    +2     
+ Misses        83485    83475   -10     
  Partials       1368     1368
Flag Coverage Δ
core 79.23% <ø> (ø)
editoast 69.27% <57.14%> (+0.03%) ⬆️
front 7.01% <0.97%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...a/fr/sncf/osrd/railjson/schema/infra/RJSInfra.java 100.00% <ø> (ø)
...ditoast/src/generated_data/error/speed_sections.rs 96.42% <100.00%> (ø)
editoast/src/generated_data/mod.rs 96.87% <100.00%> (ø)
editoast/src/generated_data/psl_sign.rs 100.00% <100.00%> (ø)
editoast/src/models/infra.rs 81.39% <ø> (ø)
editoast/src/schema/mod.rs 94.20% <ø> (ø)
editoast/src/views/layers/mvt_utils.rs 79.62% <ø> (ø)
front/src/common/Map/Consts/SignalsNames.ts 98.80% <100.00%> (ø)
front/src/reducers/map/index.ts 48.53% <100.00%> (ø)
...rc/applications/editor/tools/rangeEdition/tools.ts 0.00% <0.00%> (ø)
... and 24 more

... and 3 files with indirect coverage changes

@Bubullzz Bubullzz force-pushed the rmo/4740/rename-panel-to-sign branch 4 times, most recently from 7bfb3c7 to 4bca997 Compare August 14, 2023 12:51
@Bubullzz Bubullzz changed the title renamed Panel to Sign in the backend. Rename Panel to Sign and LPV to PSL Aug 14, 2023
@Bubullzz Bubullzz changed the title Rename Panel to Sign and LPV to PSL Rename Panel to Sign and LPV to PSL Aug 14, 2023
@kmer2016
Copy link
Contributor

kmer2016 commented Sep 4, 2023

editoast docker didn't start anymore

@kmer2016 kmer2016 requested a review from clarani September 4, 2023 13:09
flomonster
flomonster requested changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.
I only reviewed python and editoast. Waiting for final version to test it.

python/api/osrd_infra/migrations/0047_rename_lpvsignlayer_pslsignlayer.py Outdated Show resolved Hide resolved
@clarani clarani force-pushed the rmo/4740/rename-panel-to-sign branch 4 times, most recently from 4d6fe87 to 6103b03 Compare September 12, 2023 14:19
@clarani clarani marked this pull request as ready for review September 12, 2023 14:45
@clarani clarani requested review from a team as code owners September 12, 2023 14:45
@clarani
Copy link
Contributor

clarani commented Sep 12, 2023 •
edited
Loading

This PR will be merged after the drop of API, so I converted it to draft again

@clarani clarani marked this pull request as draft September 12, 2023 14:55
@clarani clarani force-pushed the rmo/4740/rename-panel-to-sign branch from 6103b03 to ae1ef00 Compare September 12, 2023 15:31
@clarani clarani force-pushed the rmo/4740/rename-panel-to-sign branch 3 times, most recently from 0ef3c64 to 0bb8e6a Compare September 28, 2023 09:23
@clarani clarani marked this pull request as ready for review September 28, 2023 10:32
@clarani clarani requested a review from eckter as a code owner September 28, 2023 10:32
@clarani clarani enabled auto-merge September 29, 2023 07:36
leovalais
leovalais reviewed Oct 2, 2023
View reviewed changes
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a few questions

editoast/src/generated_data/psl_sign.rs Show resolved Hide resolved
editoast/src/schema/speed_section.rs Show resolved Hide resolved
eckter
eckter approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@eckter eckter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor typo, otherwise LGTM (I didn't check front or editoast changes)

python/osrd_schemas/osrd_schemas/infra.py Outdated Show resolved Hide resolved
flomonster
flomonster approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed and tested.

editoast/src/generated_data/psl_sign.rs Show resolved Hide resolved
Bubullzz and others added 2 commits October 4, 2023 11:14
@clarani clarani force-pushed the rmo/4740/rename-panel-to-sign branch from 0bb8e6a to f4ba93a Compare October 4, 2023 09:16
@clarani clarani added this pull request to the merge queue Oct 4, 2023
clarani
clarani approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in local ✔️

  • all the maps: simulationMap (manageTrainSchedule and SimulationRestults), referenceMap, EditorMap, Stdcm
  • pls edition

@clarani clarani removed this pull request from the merge queue due to a manual request Oct 4, 2023
@clarani clarani added this pull request to the merge queue Oct 4, 2023
Merged via the queue into dev with commit cb78a63 Oct 4, 2023
@clarani clarani deleted the rmo/4740/rename-panel-to-sign branch October 4, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leovalais leovalais leovalais left review comments

@clarani clarani clarani approved these changes

@flomonster flomonster flomonster approved these changes

@multun multun multun approved these changes

@eckter eckter eckter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename panel to sign and lpv to psl
7 participants
@Bubullzz @kmer2016 @clarani @eckter @multun @flomonster @leovalais