editoast: electrical profile set use derive for retrive and create #4814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leovalais
approved these changes
Aug 14, 2023
Codecov Report
@@ Coverage Diff @@
## dev #4814 +/- ##
============================================
- Coverage 19.88% 19.87% -0.01%
Complexity 2245 2245
============================================
Files 877 877
Lines 90273 90258 -15
Branches 2304 2304
============================================
- Hits 17954 17942 -12
+ Misses 71036 71033 -3
Partials 1283 1283
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This test no longer makes sens, as it tested a custom implementation of retrieve that had a specific management when there was no error
Tristramg
force-pushed
the
electrical_profile_set_derive
branch
from
5c9c1a2 to
aa4300f
Compare
|
All the suggestions have been applied, thank you! |
leovalais
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.