Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: use editoast /stdcm endpoint #4824

Merged
merged 2 commits into from
Aug 22, 2023
Merged

front: use editoast /stdcm endpoint #4824

merged 2 commits into from
Aug 22, 2023

Conversation

anisometropie
Copy link
Contributor

closes #4743

@anisometropie anisometropie requested review from a team as code owners August 16, 2023 13:40
@codecov
Copy link

codecov bot commented Aug 16, 2023 •
edited
Loading

Codecov Report

Merging #4824 (5f8126b) into dev (7b172a0) will decrease coverage by 0.01%.
The diff coverage is 24.00%.

@@             Coverage Diff              @@
##                dev    #4824      +/-   ##
============================================
- Coverage     21.86%   21.86%   -0.01%     
  Complexity     2248     2248              
============================================
  Files           856      856              
  Lines         89972    89992      +20     
  Branches       2284     2284              
============================================
+ Hits          19673    19674       +1     
- Misses        69038    69057      +19     
  Partials       1261     1261
Flag Coverage Δ
editoast 73.22% <100.00%> (ø)
front 9.70% <23.23%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...tdcm/components/OldAllowances/allowancesConsts.tsx 0.00% <0.00%> (ø)
front/src/applications/stdcm/formatStcmConf.ts 0.00% <0.00%> (ø)
...src/applications/stdcm/views/StdcmRequestModal.jsx 0.00% <0.00%> (ø)
front/src/common/Pathfinding/Pathfinding.tsx 24.86% <50.00%> (ø)
editoast/src/views/stdcm/mod.rs 89.38% <100.00%> (ø)
...ront/src/applications/operationalStudies/consts.ts 78.22% <100.00%> (+0.05%) ⬆️
front/src/common/api/osrdEditoastApi.ts 92.32% <100.00%> (ø)

... and 1 file with indirect coverage changes

@anisometropie anisometropie force-pushed the vcs/stdcm-front-endpoint branch from 7fc7a69 to 7d3bfbd Compare August 16, 2023 14:51
@anisometropie anisometropie requested a review from eckter as a code owner August 17, 2023 13:44
@anisometropie anisometropie force-pushed the vcs/stdcm-front-endpoint branch from b1688d3 to 7d3bfbd Compare August 17, 2023 13:44
@anisometropie anisometropie removed the request for review from eckter August 17, 2023 15:07
@anisometropie anisometropie force-pushed the vcs/stdcm-front-endpoint branch 5 times, most recently from a73920e to 7b39ca2 Compare August 17, 2023 17:43
@anisometropie anisometropie mentioned this pull request Aug 17, 2023
Merged
@anisometropie anisometropie force-pushed the vcs/stdcm-front-endpoint branch 2 times, most recently from 238b9df to f5101d5 Compare August 18, 2023 15:01
clarani
clarani reviewed Aug 21, 2023
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good for me, only left 3 small comments :)

front/src/common/api/osrdEditoastApi.ts Outdated Show resolved Hide resolved
front/src/applications/stdcm/formatStcmConf.ts Outdated Show resolved Hide resolved
front/src/applications/stdcm/formatStcmConf.ts Outdated Show resolved Hide resolved
@anisometropie anisometropie force-pushed the vcs/stdcm-front-endpoint branch from f5101d5 to e3a2307 Compare August 21, 2023 12:28
clarani
clarani approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested in local ✔️

@anisometropie anisometropie force-pushed the vcs/stdcm-front-endpoint branch from e3a2307 to 5f8126b Compare August 21, 2023 12:36
flomonster
flomonster approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (reviewed editoast)

@anisometropie anisometropie added this pull request to the merge queue Aug 22, 2023
Merged via the queue into dev with commit f54c4dc Aug 22, 2023
@anisometropie anisometropie deleted the vcs/stdcm-front-endpoint branch August 22, 2023 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarani clarani clarani approved these changes

@flomonster flomonster flomonster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Call the new endpoint STDCM in front end
3 participants
@anisometropie @flomonster @clarani