-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add announcement ranges to the neutral section model #4862
Conversation
a6c7030
to
f08c176
Compare
Codecov Report
@@ Coverage Diff @@
## dev #4862 +/- ##
============================================
+ Coverage 22.32% 22.34% +0.01%
- Complexity 2278 2287 +9
============================================
Files 864 864
Lines 90428 90451 +23
Branches 2327 2332 +5
============================================
+ Hits 20188 20207 +19
- Misses 68962 68964 +2
- Partials 1278 1280 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ecdde98
to
da41239
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me, but I can't test as the backend is broken (500 when I want to create a train, see #4871)
core/envelope-sim/src/main/java/fr/sncf/osrd/envelope_utils/RangeMapUtils.java
Outdated
Show resolved
Hide resolved
610613f
to
3179fc9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
3179fc9
to
49d4788
Compare
closes #4661
This PR:
NeutralSections
This PR may seem a bit large, but most lines of changes comes from the update of
editoast/test/small_infra/small_infra.json
Please especially test that STDCM works fine, I'm not an expert on this part of the app, and I have some trouble diagnosing if my changes impacted it