Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: map - using flyto when clicking on a search result #4935

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

sim51
Copy link
Contributor

@sim51 sim51 commented Aug 30, 2023

How to test :

  • Go on the reference map for example
  • Go somewhere on the map
  • Click on the search icon
  • Search for a station (ex: MPM) and click on the first result

=> The map moves to the searched item with an animation (fly to)

@sim51 sim51 requested a review from a team as a code owner August 30, 2023 14:36
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #4935 (3d524d1) into dev (183d22b) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev    #4935      +/-   ##
============================================
- Coverage     22.15%   22.14%   -0.01%     
  Complexity     2287     2287              
============================================
  Files           852      852              
  Lines         90454    90473      +19     
  Branches       2341     2341              
============================================
- Hits          20037    20034       -3     
- Misses        69128    69150      +22     
  Partials       1289     1289              
Flag Coverage Δ
front 9.83% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...onalStudies/components/ManageTrainSchedule/Map.tsx 0.00% <0.00%> (ø)
...ponents/SimulationResults/SimulationResultsMap.tsx 0.00% <0.00%> (ø)
front/src/applications/referenceMap/Map.tsx 0.00% <0.00%> (ø)
front/src/common/Map/Buttons/MapButtons.tsx 0.00% <0.00%> (ø)
front/src/common/Map/Search/MapSearch.tsx 0.00% <0.00%> (ø)
front/src/common/Map/Search/MapSearchSignal.tsx 0.00% <0.00%> (ø)
front/src/reducers/map/index.ts 48.53% <ø> (-0.30%) ⬇️
front/src/reducers/map/selectors.ts 100.00% <ø> (ø)

@nicolaswurtz
Copy link
Contributor

Good job, thx !
But after rebase with dev, there's 3 typescripts errors...

@alexandredamiron alexandredamiron added this pull request to the merge queue Sep 12, 2023
Merged via the queue into dev with commit 13035f7 Sep 12, 2023
@alexandredamiron alexandredamiron deleted the bsi/fly-to branch September 12, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants