Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better signal edition #4942

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Better signal edition #4942

merged 1 commit into from
Sep 6, 2023

Conversation

flomonster
Copy link
Contributor

@flomonster flomonster commented Aug 31, 2023

This PR forces the signals parameter schema. It generate a more friendly form in the editor.

image

NOTE:

  • We still need to drop legacy fields
  • We still need to tune the UI of the generated form

@flomonster flomonster force-pushed the fam/better-signal-edition branch 2 times, most recently from dc5a43c to b6a4f4a Compare August 31, 2023 15:55
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #4942 (a9e1bde) into dev (451d16d) will increase coverage by 0.01%.
Report is 3 commits behind head on dev.
The diff coverage is 52.38%.

❗ Current head a9e1bde differs from pull request most recent head 16be0d6. Consider uploading reports for the commit 16be0d6 to get more accurate results

@@             Coverage Diff              @@
##                dev    #4942      +/-   ##
============================================
+ Coverage     22.16%   22.18%   +0.01%     
  Complexity     2287     2287              
============================================
  Files           864      864              
  Lines         90549    90431     -118     
  Branches       2352     2353       +1     
============================================
- Hits          20072    20062      -10     
+ Misses        69177    69070     -107     
+ Partials       1300     1299       -1     
Flag Coverage Δ
front 9.86% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
editoast/src/models/infra.rs 81.39% <ø> (ø)
editoast/src/schema/mod.rs 91.30% <ø> (ø)
editoast/src/schema/signal.rs 50.00% <ø> (ø)
.../fr/sncf/osrd/sim_infra_adapter/RawInfraAdapter.kt 90.15% <27.77%> (-2.63%) ⬇️
.../railjson/schema/infra/trackobjects/RJSSignal.java 72.41% <63.15%> (-17.59%) ⬇️
...a/fr/sncf/osrd/railjson/schema/infra/RJSInfra.java 100.00% <100.00%> (ø)
editoast/src/converters/utils.rs 87.12% <100.00%> (-0.15%) ⬇️
editoast/src/schema/signaling_systems.rs 100.00% <100.00%> (ø)

... and 16 files with indirect coverage changes

@flomonster flomonster force-pushed the fam/better-signal-edition branch 3 times, most recently from 21b0c10 to 5f94ece Compare September 1, 2023 12:45
@flomonster flomonster marked this pull request as ready for review September 1, 2023 12:46
@flomonster flomonster requested review from a team as code owners September 1, 2023 12:46
@flomonster flomonster force-pushed the fam/better-signal-edition branch from 5f94ece to cacdf95 Compare September 1, 2023 13:11
python/osrd_schemas/osrd_schemas/infra.py Outdated Show resolved Hide resolved
python/osrd_schemas/osrd_schemas/infra.py Outdated Show resolved Hide resolved
python/osrd_schemas/osrd_schemas/infra.py Outdated Show resolved Hide resolved
@flomonster flomonster force-pushed the fam/better-signal-edition branch from a9e1bde to 9c6b21f Compare September 1, 2023 13:45
@flomonster flomonster requested a review from Khoyo September 1, 2023 13:45
@flomonster flomonster force-pushed the fam/better-signal-edition branch from 9c6b21f to 6095b93 Compare September 4, 2023 16:00
@flomonster flomonster requested a review from multun as a code owner September 4, 2023 16:00
@flomonster flomonster force-pushed the fam/better-signal-edition branch from 6095b93 to 4305a4f Compare September 5, 2023 12:00
@flomonster flomonster force-pushed the fam/better-signal-edition branch from 4305a4f to 16be0d6 Compare September 5, 2023 14:50
@flomonster flomonster self-assigned this Sep 6, 2023
@flomonster flomonster merged commit 3e1b54c into dev Sep 6, 2023
@flomonster flomonster deleted the fam/better-signal-edition branch September 6, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants