-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: incremental spacing resource generation #5040
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9fd6f3a
to
4e7e161
Compare
Codecov Report
@@ Coverage Diff @@
## dev #5040 +/- ##
============================================
+ Coverage 22.83% 22.92% +0.09%
+ Complexity 2461 2450 -11
============================================
Files 849 853 +4
Lines 90118 90290 +172
Branches 2448 2482 +34
============================================
+ Hits 20576 20702 +126
- Misses 68204 68227 +23
- Partials 1338 1361 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
|
multun
reviewed
Sep 13, 2023
multun
reviewed
Sep 13, 2023
core/src/main/java/fr/sncf/osrd/conflicts/RoutingResourceGenerator.kt
Outdated
Show resolved
Hide resolved
multun
reviewed
Sep 13, 2023
core/src/main/java/fr/sncf/osrd/standalone_sim/ScheduleMetadataExtractor.kt
Outdated
Show resolved
Hide resolved
Switch the spacing resource generation to an incremental generator, in preparation for the STDCM integration. Currently, it is only called in one go by the standalone simulation. Co-Authored-By: Victor "multun" Collod <[email protected]> Co-Authored-By: Younes "khoyo" Khoudli <[email protected]>
4e7e161
to
d1788fd
Compare
multun
approved these changes
Sep 14, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch the spacing resource generation to an incremental generator, in
preparation for the STDCM integration. Currently, it is only called in
one go by the standalone simulation.
Co-Authored-By: Victor "multun" Collod [email protected]
Co-Authored-By: Younes "khoyo" Khoudli [email protected]