core: migrate stdcm to new infra #5128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eckter
force-pushed
the
stdcm-migration
branch
from
6bc7b6f to
b93155d
Compare
Codecov Report
@@ Coverage Diff @@
## dev #5128 +/- ##
============================================
- Coverage 18.88% 18.61% -0.28%
+ Complexity 2469 2318 -151
============================================
Files 860 855 -5
Lines 104612 104190 -422
Branches 2512 2408 -104
============================================
- Hits 19761 19399 -362
+ Misses 83483 83451 -32
+ Partials 1368 1340 -28
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This was
linked to
issues
Sep 21, 2023
eckter
force-pushed
the
stdcm-migration
branch
2 times, most recently
from
cc8c994 to
dbfcc41
Compare
Erashin
force-pushed
the
stdcm-migration
branch
3 times, most recently
from
e79792b to
844aaec
Compare
eckter
force-pushed
the
stdcm-migration
branch
from
475a84f to
54ae866
Compare
3 tasks
Khoyo
reviewed
Sep 29, 2023
core/kt-osrd-utils/src/main/kotlin/fr/sncf/osrd/utils/DistanceRangeMapImpl.kt
Outdated
Show resolved
Hide resolved
multun
suggested changes
Sep 29, 2023
core/kt-osrd-sim-infra/src/main/kotlin/fr/sncf/osrd/sim_infra/api/RawSignalingInfra.kt
Outdated
Show resolved
Hide resolved
core/kt-osrd-sim-infra/src/main/kotlin/fr/sncf/osrd/sim_infra/impl/BlockInfraImpl.kt
Outdated
Show resolved
Hide resolved
core/kt-osrd-sim-infra/src/main/kotlin/fr/sncf/osrd/sim_infra/impl/BlockInfraImpl.kt
Outdated
Show resolved
Hide resolved
core/kt-osrd-sim-infra/src/main/kotlin/fr/sncf/osrd/sim_infra/impl/RawInfraImpl.kt
Outdated
Show resolved
Hide resolved
core/src/main/java/fr/sncf/osrd/standalone_sim/SignalProjection.kt
Outdated
Show resolved
Hide resolved
core/src/main/java/fr/sncf/osrd/stdcm/graph/AllowanceManager.java
Outdated
Show resolved
Hide resolved
Erashin
force-pushed
the
stdcm-migration
branch
from
54ae866 to
b7a709e
Compare
multun
reviewed
Oct 5, 2023
core/kt-osrd-sim-infra/src/main/kotlin/fr/sncf/osrd/sim_infra/api/PathProperties.kt
Outdated
Show resolved
Hide resolved
core/kt-osrd-sim-infra/src/main/kotlin/fr/sncf/osrd/sim_infra/impl/RawInfraBuilder.kt
Show resolved
Hide resolved
core/kt-osrd-sim-infra/src/main/kotlin/fr/sncf/osrd/sim_infra/impl/RawInfraBuilder.kt
Show resolved
Hide resolved
core/kt-osrd-sim-infra/src/main/kotlin/fr/sncf/osrd/sim_infra/impl/RawInfraImpl.kt
Show resolved
Hide resolved
eckter
force-pushed
the
stdcm-migration
branch
2 times, most recently
from
88720ef to
86a1385
Compare
multun
approved these changes
Oct 6, 2023
Change summary: * Migrate train simulation code to work with the new infra interfaces * Migrate STDCM to work with the new infra interfaces * Run the STDCM pathfinding on blocks instead of routes * Migrate tests, using a new class to build simplified infras * Cleanup some legacy code (not all of it)
There is already a non-empty assert in all call sites. For STDCM preprocessing this error is triggered too often (because of poor signaling data in imported infras), and an empty result isn't a problem in this case
eckter
force-pushed
the
stdcm-migration
branch
from
1e21b2d to
1e82e00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary:
Note: the STDCM changes are fairly minimal (mostly renames and simple replacements). Most of the changes are STDCM dependencies, especially standalone sim. This PR can be reviewed by someone who isn't familiar with the STDCM module.
Parts of it have already been reviewed in #5017, but it sounded more realistic to squash everything before the rebase.