Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: add GLOTT loading gauge type #5159

Merged
merged 1 commit into from
Sep 29, 2023
Merged

core: add GLOTT loading gauge type #5159

merged 1 commit into from
Sep 29, 2023

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Sep 29, 2023

No description provided.

@eckter eckter requested a review from a team as a code owner September 29, 2023 09:03
@eckter eckter linked an issue Sep 29, 2023 that may be closed by this pull request
@eckter eckter force-pushed the ech/fix-loading-gauge branch from d3c2bed to 35fb15d Compare September 29, 2023 09:07
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #5159 (35fb15d) into dev (5da16c9) will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff            @@
##                dev    #5159   +/-   ##
=========================================
  Coverage     18.55%   18.55%           
  Complexity     2466     2466           
=========================================
  Files           859      859           
  Lines        106263   106265    +2     
  Branches       2499     2499           
=========================================
+ Hits          19714    19715    +1     
- Misses        85182    85183    +1     
  Partials       1367     1367           
Flag Coverage Δ
core 79.18% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ljson/schema/rollingstock/RJSLoadingGaugeType.java 100.00% <100.00%> (ø)
...tion/tracks/undirected/UndirectedInfraBuilder.java 86.01% <0.00%> (-0.31%) ⬇️

@multun
Copy link
Contributor

multun commented Sep 29, 2023

I'm a bit hesitant: the code change is fine, but I cannot find any reference to GLOTT online. I'm worried it might be some kind of weird special case. No knowing what that is also prevents us from adding a correct compatibility list.

EDIT: found it, it's for trams

@multun multun added this pull request to the merge queue Sep 29, 2023
Merged via the queue into dev with commit ca6072f Sep 29, 2023
@multun multun deleted the ech/fix-loading-gauge branch September 29, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug at pathfinding when using a train with "GLOTT" loading gauge
2 participants