Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editoast: add cli commands to list / delete electrical profile sets #5167

Merged
merged 1 commit into from
Oct 2, 2023
Merged

editoast: add cli commands to list / delete electrical profile sets #5167

merged 1 commit into from
Oct 2, 2023

Conversation

Castavo
Copy link
Contributor

@Castavo Castavo commented Sep 29, 2023

closes #5165

@Castavo Castavo requested a review from a team as a code owner September 29, 2023 15:45
@Castavo Castavo force-pushed the bpt/editoast/cli-electrical-profiles branch from 58bb5e6 to b197f61 Compare September 29, 2023 15:49
@codecov
Copy link

codecov bot commented Sep 29, 2023 •
edited
Loading

Codecov Report

Merging #5167 (caacf59) into dev (afe8391) will increase coverage by 0.01%.
The diff coverage is 70.96%.

@@             Coverage Diff              @@
##                dev    #5167      +/-   ##
============================================
+ Coverage     18.60%   18.61%   +0.01%     
  Complexity     2469     2469              
============================================
  Files           859      859              
  Lines        106413   106439      +26     
  Branches       2500     2500              
============================================
+ Hits          19800    19818      +18     
- Misses        85246    85254       +8     
  Partials       1367     1367
Flag Coverage Δ
editoast 69.20% <70.96%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
editoast/src/client/mod.rs 100.00% <ø> (ø)
editoast/src/models/electrical_profile.rs 100.00% <100.00%> (ø)
editoast/src/views/electrical_profiles.rs 91.30% <ø> (-1.01%) ⬇️
editoast/src/main.rs 14.34% <67.85%> (+6.78%) ⬆️

... and 1 file with indirect coverage changes

@Castavo Castavo requested a review from leovalais September 29, 2023 16:05
leovalais
leovalais reviewed Oct 2, 2023
View reviewed changes
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mostly, left a few questions

editoast/src/main.rs Outdated Show resolved Hide resolved
editoast/src/client/mod.rs Outdated Show resolved Hide resolved
leovalais
leovalais reviewed Oct 2, 2023
View reviewed changes
editoast/src/main.rs Outdated Show resolved Hide resolved
@Castavo Castavo requested a review from leovalais October 2, 2023 13:11
leovalais
leovalais approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@leovalais leovalais left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested prior your last changes. Rebase auto squash

editoast/src/main.rs Outdated Show resolved Hide resolved
@Castavo Castavo force-pushed the bpt/editoast/cli-electrical-profiles branch from 767d5bf to 2f8e1fe Compare October 2, 2023 14:36
@Castavo Castavo force-pushed the bpt/editoast/cli-electrical-profiles branch from 2f8e1fe to caacf59 Compare October 2, 2023 14:44
@Castavo Castavo enabled auto-merge October 2, 2023 14:44
@Castavo Castavo added this pull request to the merge queue Oct 2, 2023
Merged via the queue into dev with commit 6fc6ddb Oct 2, 2023
@Castavo Castavo deleted the bpt/editoast/cli-electrical-profiles branch October 2, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leovalais leovalais leovalais approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write an editoast cli to list / delete electrical profile sets
2 participants
@Castavo @leovalais