Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: infra is displayed on the warped map #5214

Merged
merged 1 commit into from
Oct 6, 2023
Merged

front: infra is displayed on the warped map #5214

merged 1 commit into from
Oct 6, 2023

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Oct 5, 2023

closes #5158

@clarani clarani requested a review from a team as a code owner October 5, 2023 09:44
@clarani clarani added the area:front Work on Standard OSRD Interface modules label Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #5214 (a006526) into dev (939092a) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev    #5214      +/-   ##
============================================
- Coverage     18.87%   18.87%   -0.01%     
  Complexity     2469     2469              
============================================
  Files           860      860              
  Lines        104584   104586       +2     
  Branches       2512     2512              
============================================
  Hits          19744    19744              
- Misses        83472    83474       +2     
  Partials       1368     1368
Flag Coverage Δ
front 7.02% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
front/src/common/Map/WarpedMap/DataLoader.tsx 0.00% <0.00%> (ø)
front/src/common/Map/WarpedMap/WarpedMap.tsx 0.00% <0.00%> (ø)

Uriel-Sautron
Uriel-Sautron approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, tested on local good for me !

@clarani clarani added this pull request to the merge queue Oct 6, 2023
Merged via the queue into dev with commit 8ba02da Oct 6, 2023
@clarani clarani deleted the cni-5158-warped-map-bug branch October 6, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uriel-Sautron Uriel-Sautron Uriel-Sautron approved these changes

@nicolaswurtz nicolaswurtz nicolaswurtz approved these changes

Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

front: infra is not displayed on the warped map
3 participants
@clarani @nicolaswurtz @Uriel-Sautron