-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: separate chunk path from PathProperties #5241
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #5241 +/- ##
=========================================
Coverage 18.75% 18.76%
+ Complexity 2320 2318 -2
=========================================
Files 852 852
Lines 103348 103361 +13
Branches 2408 2408
=========================================
+ Hits 19384 19395 +11
- Misses 82626 82628 +2
Partials 1338 1338
Flags with carried forward coverage won't be shown. Click here to find out more.
|
1e21b2d
to
1e82e00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't there a problem in the commits of this PR ? I feel like i've already reviewed those changes in another PR 🤔
Only the last commit matters, the rest just means the branch needs to be rebased |
15f6739
to
32e19ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
core/kt-osrd-sim-infra/src/main/kotlin/fr/sncf/osrd/sim_infra/impl/PathPropertiesImpl.kt
Show resolved
Hide resolved
core/kt-osrd-sim-infra/src/main/kotlin/fr/sncf/osrd/sim_infra/impl/PathPropertiesImpl.kt
Show resolved
Hide resolved
32e19ba
to
bdf933b
Compare
bdf933b
to
37df1bf
Compare
Fixes #5242.