Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

osrd-schemas: update the order in which schemas are rebuilt #5259

Merged
merged 1 commit into from
Oct 10, 2023
Merged

osrd-schemas: update the order in which schemas are rebuilt #5259

merged 1 commit into from
Oct 10, 2023

Conversation

Castavo
Copy link
Contributor

@Castavo Castavo commented Oct 9, 2023

No description provided.

@Castavo Castavo requested a review from a team as a code owner October 9, 2023 15:58
@Castavo Castavo force-pushed the bpt/update-schemas-rebuild branch from c601f49 to 8733999 Compare October 9, 2023 16:03
@codecov
Copy link

codecov bot commented Oct 9, 2023 •
edited
Loading

Codecov Report

Merging #5259 (4816593) into dev (e0a1bb7) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev    #5259   +/-   ##
=========================================
  Coverage     18.66%   18.66%           
  Complexity     2318     2318           
=========================================
  Files           856      856           
  Lines        104007   104007           
  Branches       2409     2409           
=========================================
  Hits          19409    19409           
  Misses        83257    83257           
  Partials       1341     1341
Flag Coverage Δ
core 78.97% <ø> (ø)
front 7.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Castavo Castavo force-pushed the bpt/update-schemas-rebuild branch from 8733999 to 460be14 Compare October 10, 2023 07:00
@Castavo Castavo force-pushed the bpt/update-schemas-rebuild branch from 460be14 to 4816593 Compare October 10, 2023 07:03
@Castavo Castavo requested a review from leovalais October 10, 2023 09:02
flomonster
flomonster approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix!
LGTM and tested.

@Castavo Castavo added this pull request to the merge queue Oct 10, 2023
Merged via the queue into dev with commit 6ee2d72 Oct 10, 2023
@Castavo Castavo deleted the bpt/update-schemas-rebuild branch October 10, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flomonster flomonster flomonster approved these changes

@leovalais leovalais Awaiting requested review from leovalais

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Castavo @flomonster