Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: prevent pathfinding from reloading on each re-render #5277

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Oct 10, 2023

closes #5123

@clarani clarani requested a review from a team as a code owner October 10, 2023 13:18
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #5277 (20037dc) into dev (087973a) will increase coverage by 0.00%.
Report is 2 commits behind head on dev.
The diff coverage is 11.53%.

@@            Coverage Diff            @@
##                dev    #5277   +/-   ##
=========================================
  Coverage     18.73%   18.73%           
  Complexity     2308     2308           
=========================================
  Files           849      849           
  Lines        103050   103017   -33     
  Branches       2390     2391    +1     
=========================================
- Hits          19307    19304    -3     
+ Misses        82411    82380   -31     
- Partials       1332     1333    +1     
Flag Coverage Δ
front 7.09% <11.53%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ront/src/applications/operationalStudies/consts.ts 78.11% <ø> (-0.06%) ⬇️
...s/RollingStockSelector/RollingStockCardButtons.tsx 0.00% <ø> (ø)
...rainSchedule/ManageTrainScheduleMap/setPointIti.ts 0.00% <ø> (ø)
front/src/reducers/osrdconf/index.ts 33.38% <ø> (+0.18%) ⬆️
front/src/reducers/osrdconf/selectors.ts 82.08% <ø> (-0.27%) ⬇️
...ents/ManageTrainSchedule/Itinerary/DisplayVias.tsx 0.00% <0.00%> (ø)
...anageTrainSchedule/Itinerary/ModalSuggeredVias.tsx 0.00% <0.00%> (ø)
...s/operationalStudies/views/ManageTrainSchedule.tsx 0.00% <0.00%> (ø)
...edule/components/ManageTrainSchedule/Itinerary.tsx 0.00% <0.00%> (ø)
front/src/common/Pathfinding/Pathfinding.tsx 24.65% <15.00%> (-0.13%) ⬇️

... and 1 file with indirect coverage changes

@clarani clarani force-pushed the cni-5123-prevent-pathfinding-from-reloading branch 2 times, most recently from 8f61578 to d6facd7 Compare October 13, 2023 12:47
@clarani clarani force-pushed the cni-5123-prevent-pathfinding-from-reloading branch from d6facd7 to bc44e34 Compare October 13, 2023 15:19
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, tested in manageTrainSchedule and with importing trains and everything works as it should.

Left just one suggestion :)

front/src/common/Pathfinding/Pathfinding.tsx Outdated Show resolved Hide resolved
@clarani clarani force-pushed the cni-5123-prevent-pathfinding-from-reloading branch from bc44e34 to 20037dc Compare October 16, 2023 09:23
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in local, it improve the app, good job

@clarani clarani enabled auto-merge October 18, 2023 10:19
@clarani clarani added this pull request to the merge queue Oct 18, 2023
Merged via the queue into dev with commit 358b34a Oct 18, 2023
@clarani clarani deleted the cni-5123-prevent-pathfinding-from-reloading branch October 18, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: pathfinding is reloaded each time we click on the tab pathfinding
4 participants