-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: prevent pathfinding from reloading on each re-render #5277
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #5277 +/- ##
=========================================
Coverage 18.73% 18.73%
Complexity 2308 2308
=========================================
Files 849 849
Lines 103050 103017 -33
Branches 2390 2391 +1
=========================================
- Hits 19307 19304 -3
+ Misses 82411 82380 -31
- Partials 1332 1333 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
8f61578
to
d6facd7
Compare
front/src/applications/operationalStudies/views/ManageTrainSchedule.tsx
Outdated
Show resolved
Hide resolved
d6facd7
to
bc44e34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, tested in manageTrainSchedule and with importing trains and everything works as it should.
Left just one suggestion :)
bc44e34
to
20037dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in local, it improve the app, good job
closes #5123