core: stdcm: memoize simulateBlock #5284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eckter
force-pushed
the
ech/add-large-timetable-tests
branch
from
03f1386 to
370ec64
Compare
Erashin
force-pushed
the
alch/memoize-simulated-block-envelopes
branch
from
b4ca116 to
33ae0fc
Compare
Erashin
force-pushed
the
alch/memoize-simulated-block-envelopes
branch
from
33ae0fc to
109fd5c
Compare
Codecov Report
@@ Coverage Diff @@
## dev #5284 +/- ##
============================================
+ Coverage 18.73% 18.74% +0.01%
- Complexity 2318 2322 +4
============================================
Files 852 853 +1
Lines 103510 103524 +14
Branches 2402 2402
============================================
+ Hits 19396 19410 +14
Misses 82774 82774
Partials 1340 1340
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Erashin
force-pushed
the
alch/memoize-simulated-block-envelopes
branch
from
109fd5c to
0b583ee
Compare
Khoyo
approved these changes
Oct 11, 2023
...ain/java/fr/sncf/osrd/stdcm/preprocessing/implementation/BlockAvailabilityLegacyAdapter.java
Show resolved
Hide resolved
eckter
reviewed
Oct 11, 2023
Add computed block envelopes to STDCMGraph. Only compute block envelopes which have not been already computed.
Erashin
force-pushed
the
alch/memoize-simulated-block-envelopes
branch
from
0b583ee to
9c9cabd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add computed block envelopes to STDCMGraph. Only compute block envelopes which have not been already computed.
Makes this test pass in 3mn8s (was not passing beforehand).