Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db: fix: set all null sign values to empty strings #5303

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Conversation

Khoyo
Copy link
Contributor

@Khoyo Khoyo commented Oct 12, 2023

No description provided.

@Khoyo Khoyo requested a review from a team as a code owner October 12, 2023 09:45
@Khoyo Khoyo force-pushed the yk/fix-sign-value branch from 9703552 to 476835d Compare October 12, 2023 09:57
@Khoyo Khoyo self-assigned this Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #5303 (f62e58e) into dev (e32e129) will decrease coverage by 0.01%.
Report is 13 commits behind head on dev.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #5303      +/-   ##
============================================
- Coverage     18.75%   18.75%   -0.01%     
  Complexity     2318     2318              
============================================
  Files           852      852              
  Lines        103448   103448              
  Branches       2408     2408              
============================================
- Hits          19404    19401       -3     
- Misses        82706    82709       +3     
  Partials       1338     1338              
Flag Coverage Δ
editoast 69.97% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Reviewed + Tested

@Khoyo Khoyo added this pull request to the merge queue Oct 12, 2023
@Khoyo Khoyo removed this pull request from the merge queue due to a manual request Oct 12, 2023
@Khoyo Khoyo force-pushed the yk/fix-sign-value branch from 476835d to f62e58e Compare October 12, 2023 10:44
@Khoyo Khoyo enabled auto-merge October 12, 2023 10:46
@Khoyo Khoyo added this pull request to the merge queue Oct 12, 2023
Merged via the queue into dev with commit d23d219 Oct 12, 2023
@Khoyo Khoyo deleted the yk/fix-sign-value branch October 12, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants