Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editoast: forward core error type #5352

Merged
merged 2 commits into from
Oct 24, 2023
Merged

editoast: forward core error type #5352

merged 2 commits into from
Oct 24, 2023

Conversation

Khoyo
Copy link
Contributor

@Khoyo Khoyo commented Oct 16, 2023 •
edited
Loading

Fixes #5350.
Fixes #5244.

@Khoyo Khoyo added the area:editoast Work on Editoast Service label Oct 16, 2023
@Khoyo Khoyo self-assigned this Oct 16, 2023
@Khoyo Khoyo requested a review from a team as a code owner October 16, 2023 09:13
@Khoyo Khoyo force-pushed the yk/forward-core-error-type branch 2 times, most recently from c6f5384 to 681c4a0 Compare October 16, 2023 12:51
@codecov
Copy link

codecov bot commented Oct 16, 2023 •
edited
Loading

Codecov Report

Merging #5352 (496a491) into dev (76f1ed2) will decrease coverage by 0.05%.
Report is 14 commits behind head on dev.
The diff coverage is 84.21%.

@@             Coverage Diff              @@
##                dev    #5352      +/-   ##
============================================
- Coverage     18.88%   18.84%   -0.05%     
  Complexity     2315     2315              
============================================
  Files           854      854              
  Lines        102769   102820      +51     
  Branches       2403     2403              
============================================
- Hits          19413    19381      -32     
- Misses        82015    82098      +83     
  Partials       1341     1341
Flag Coverage Δ
editoast 69.94% <83.33%> (+0.23%) ⬆️
front 7.11% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
front/src/common/api/osrdEditoastApi.ts 91.88% <100.00%> (+0.12%) ⬆️
editoast/src/error.rs 28.98% <50.00%> (+3.61%) ⬆️
editoast/src/core/mod.rs 58.33% <87.50%> (+15.03%) ⬆️

... and 12 files with indirect coverage changes

@leovalais leovalais mentioned this pull request Oct 16, 2023
Merged
@leovalais
editoast: improve CoreClient error management
90a3c03 
Also adds error support for MockingClient.
@Khoyo Khoyo force-pushed the yk/forward-core-error-type branch 8 times, most recently from f7565af to 42199cf Compare October 24, 2023 14:43
leovalais
leovalais requested changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & tested. @Tguisnet could you review this as well since I worked a little on this?

editoast/src/core/mod.rs Show resolved Hide resolved
editoast/src/core/mod.rs Outdated Show resolved Hide resolved
leovalais
leovalais approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @Tguisnet is reviewing it

Tguisnet
Tguisnet approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@Tguisnet Tguisnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Khoyo Khoyo force-pushed the yk/forward-core-error-type branch from 2581c16 to 496a491 Compare October 24, 2023 16:05
@Khoyo Khoyo enabled auto-merge October 24, 2023 16:05
@Khoyo Khoyo added this pull request to the merge queue Oct 24, 2023
Merged via the queue into dev with commit 1087edd Oct 24, 2023
@Khoyo Khoyo deleted the yk/forward-core-error-type branch October 24, 2023 16:30
This was referenced Oct 26, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tguisnet Tguisnet Tguisnet approved these changes

@leovalais leovalais leovalais approved these changes

Assignees

@Khoyo Khoyo

Labels
area:editoast Work on Editoast Service
Projects
None yet
Milestone
No milestone
3 participants
@Khoyo @leovalais @Tguisnet