core: fix allowance space search discontinuities #5399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erashin
force-pushed
the
ech/reproduce-search-space-discontinuity
branch
from
933e3fa to
40070b8
Compare
Erashin
changed the title
Erashin
changed the title
Erashin
changed the title
Erashin
force-pushed
the
ech/reproduce-search-space-discontinuity
branch
5 times, most recently
from
f1890d7 to
ce36774
Compare
Erashin
force-pushed
the
ech/reproduce-search-space-discontinuity
branch
from
ce36774 to
a2a3f4b
Compare
Erashin
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #5399 +/- ##
=========================================
Coverage 19.58% 19.58%
- Complexity 2326 2327 +1
=========================================
Files 886 886
Lines 106098 106105 +7
Branches 2576 2576
=========================================
+ Hits 20777 20780 +3
- Misses 83812 83813 +1
- Partials 1509 1512 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
multun
suggested changes
Nov 17, 2023
core/envelope-sim/src/main/java/fr/sncf/osrd/envelope/part/EnvelopePart.java
Outdated
Show resolved
Hide resolved
eckter
commented
Nov 17, 2023
Erashin
force-pushed
the
ech/reproduce-search-space-discontinuity
branch
from
a2a3f4b to
0d8bdbc
Compare
axrolld
approved these changes
Nov 17, 2023
multun
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple of coasting problems for Mareco allowances, creating discontinuities in the search space for a solution validating said allowance.
First discontinuity was due to
coastFromBeginningnot starting at thestartSpeedfound whencoastFromEndnever reaches the envelope. The solutions would then always fluctuate between braking=>coasting and coasting=>braking, but never with any solution in the middle.Second discontinuity was due to
EnvelopePartnot always having anEnvelopeProfileattribute, in this case, theBrakingone: coasting opportunities were not found because of that (braking opportunities are found by firstly checking if saidEnvelopeParthas aBrakingattribute). It is now compulsory.Comparison between doubles played a small part in this: a PR will be arriving to use
areSpeedsEqualeverywhere (as long as I find all the comparisons).