core: fix identical positions when shifting envelope parts #5432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #5432 +/- ##
=========================================
Coverage 18.89% 18.89%
Complexity 2315 2315
=========================================
Files 854 854
Lines 102770 102781 +11
Branches 2403 2404 +1
=========================================
+ Hits 19414 19424 +10
Misses 82015 82015
- Partials 1341 1342 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
eckter
force-pushed
the
ech/fix-strictly-increasing-positions
branch
from
fbbfc28 to
de36376
Compare
multun
suggested changes
Oct 24, 2023
core/envelope-sim/src/main/java/fr/sncf/osrd/envelope/part/EnvelopePart.java
Outdated
Show resolved
Hide resolved
core/envelope-sim/src/main/java/fr/sncf/osrd/envelope/part/EnvelopePart.java
Outdated
Show resolved
Hide resolved
eckter
force-pushed
the
ech/fix-strictly-increasing-positions
branch
from
de36376 to
0353a9d
Compare
Erashin
approved these changes
Oct 30, 2023
multun
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5426
I couldn't quite reproduced it in a regression test, but I found a scenario that reproduced it and it was fixed after this change.