Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: router: add id support on EEX routes, need to replace modal cont… #5435

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

Math-R
Copy link
Contributor

@Math-R Math-R commented Oct 23, 2023

…ext by react createPortal hook

close #3661

@Math-R Math-R force-pushed the mrd/new-routing branch 5 times, most recently from 4bfb614 to 6c16cb5 Compare November 7, 2023 09:10
@Math-R Math-R marked this pull request as ready for review November 7, 2023 09:11
@Math-R Math-R requested a review from a team as a code owner November 7, 2023 09:11
@Math-R Math-R changed the title WIP : front: add id support on EEX routes, need to replace modal cont… front: router: add id support on EEX routes, need to replace modal cont… Nov 7, 2023
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments, can you apply these changes in Project but also Study and Scenario ? Also you have 4 warnings and some functions are commented in ProjectCard, but it breaks a behaviour

@Math-R Math-R force-pushed the mrd/new-routing branch 3 times, most recently from 002d0fa to 4c59dcd Compare November 9, 2023 10:34
…lementation in prevision of createPortal use
@Math-R Math-R force-pushed the mrd/new-routing branch 2 times, most recently from 95f65c3 to 29d7ffa Compare November 9, 2023 10:49
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #5435 (77febea) into dev (24c2796) will decrease coverage by 0.04%.
Report is 1 commits behind head on dev.
The diff coverage is 0.39%.

@@             Coverage Diff              @@
##                dev    #5435      +/-   ##
============================================
- Coverage     19.61%   19.58%   -0.04%     
  Complexity     2322     2322              
============================================
  Files           879      884       +5     
  Lines        105591   105788     +197     
  Branches       2566     2571       +5     
============================================
  Hits          20716    20716              
- Misses        83372    83564     +192     
- Partials       1503     1508       +5     
Flag Coverage Δ
front 8.34% <0.39%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
front/src/applications/operationalStudies/Home.tsx 0.00% <0.00%> (ø)
...c/common/BootstrapSNCF/ModalSNCF/ModalProvider.tsx 32.14% <50.00%> (-0.20%) ⬇️
...t/src/modules/scenario/components/ScenarioCard.tsx 0.00% <0.00%> (ø)
front/src/modules/study/components/StudyCard.tsx 0.00% <0.00%> (ø)
...Schedule/Allowances/AllowancesStandardSettings.tsx 0.00% <0.00%> (ø)
front/src/common/osrdConfContext.tsx 0.00% <0.00%> (ø)
...dules/project/components/AddOrEditProjectModal.tsx 0.00% <0.00%> (ø)
front/src/applications/editor/Home.tsx 0.00% <0.00%> (ø)
front/src/applications/referenceMap/Home.tsx 0.00% <0.00%> (ø)
front/src/applications/rollingStockEditor/Home.tsx 0.00% <0.00%> (ø)
... and 11 more

... and 8 files with indirect coverage changes

@Math-R Math-R force-pushed the mrd/new-routing branch 2 times, most recently from bdce16c to a3ef503 Compare November 9, 2023 12:19
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested ✅

@Math-R Math-R added this pull request to the merge queue Nov 9, 2023
@Math-R Math-R removed this pull request from the merge queue due to a manual request Nov 9, 2023
@Math-R Math-R added this pull request to the merge queue Nov 9, 2023
@Math-R Math-R removed this pull request from the merge queue due to a manual request Nov 9, 2023
@Math-R Math-R enabled auto-merge November 9, 2023 17:32
@Math-R Math-R added this pull request to the merge queue Nov 9, 2023
Merged via the queue into dev with commit 965f94f Nov 9, 2023
@Math-R Math-R deleted the mrd/new-routing branch November 9, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: new routing system (slug)
3 participants