-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: router: add id support on EEX routes, need to replace modal cont… #5435
Conversation
4bfb614
to
6c16cb5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments, can you apply these changes in Project but also Study and Scenario ? Also you have 4 warnings and some functions are commented in ProjectCard, but it breaks a behaviour
002d0fa
to
4c59dcd
Compare
…lementation in prevision of createPortal use
95f65c3
to
29d7ffa
Compare
Codecov Report
@@ Coverage Diff @@
## dev #5435 +/- ##
============================================
- Coverage 19.61% 19.58% -0.04%
Complexity 2322 2322
============================================
Files 879 884 +5
Lines 105591 105788 +197
Branches 2566 2571 +5
============================================
Hits 20716 20716
- Misses 83372 83564 +192
- Partials 1503 1508 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bdce16c
to
a3ef503
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested ✅
a3ef503
to
79842ae
Compare
79842ae
to
77febea
Compare
…ext by react createPortal hook
close #3661