-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: fix when no curves are selected in rolling stock curve component #5481
front: fix when no curves are selected in rolling stock curve component #5481
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #5481 +/- ##
============================================
- Coverage 19.47% 19.46% -0.01%
Complexity 2320 2320
============================================
Files 871 871
Lines 104778 104806 +28
Branches 2538 2538
============================================
Hits 20402 20402
- Misses 82902 82930 +28
Partials 1474 1474
Flags with carried forward coverage won't be shown. Click here to find out more.
|
4f0c545
to
2a4ca1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, tested in local and works as expected :)
If you can just remove the uppercase from your commit and it's perfect.
Shouldn't we see the graph (with scales) without curves when nothing is selected? |
I asked that myself but as it's the same behavior in the rolling stock editor, thought it was intended. But seems a bit weird yes. |
This is how the graph lib works, without the data it cannot build the axes or you have to find a way to give it axes by default (I can look at the lib doc to find that) |
In the meantime i can keep the axes names |
I agree thath the scales should remain if that's possible. Also, be careful when sharing screenshots of rolling stocks on github, the data are not public 😬 We're not supposed to identify a rolling stock with its corresponding data. |
46b002c
to
bab817b
Compare
disable the ability to deselect the last curve
bab817b
to
6172c3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested ✔️
close #5365