-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editoast: bump dependencies #5500
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #5500 +/- ##
============================================
- Coverage 18.79% 18.79% -0.01%
Complexity 2320 2320
============================================
Files 861 861
Lines 103573 103573
Branches 2412 2412
============================================
- Hits 19467 19465 -2
- Misses 82758 82760 +2
Partials 1348 1348
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your first contribution! 🎉
Can you fixup your commits together?
Some guidelines to follow:
- ✅ Try to have atomic commits (each commit should add something)
- ❌ No commits that correct commits within the same PR
- ✅ Make PR as minimalist as possible
Why we require this:
- Keep our git history as clean as possible and easy to revert
- Make as simple as possible the review of PR
- Increases the speed with which a PR will be reviewed and thus merge
973d43a
to
f67891f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- There are three new missing closing PR in your description: checkout this
- Can you clean up your commit message (You squashed your commits instead of fix up)
- Some dependencies have recently been bump (
serde
,serde_derive
,serde_yaml
,futures
,tempfile
)utoipa
as a new major version with breaking changes. We can bump it later with the required fixes.
f67891f
to
c11a6ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
closes: #5470