Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: bump dependencies #5500

Merged
merged 1 commit into from
Oct 27, 2023
Merged

editoast: bump dependencies #5500

merged 1 commit into from
Oct 27, 2023

Conversation

hamz2a
Copy link
Contributor

@hamz2a hamz2a commented Oct 26, 2023

closes: #5470

@hamz2a hamz2a requested a review from a team as a code owner October 26, 2023 15:20
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #5500 (c11a6ef) into dev (19a7720) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #5500      +/-   ##
============================================
- Coverage     18.79%   18.79%   -0.01%     
  Complexity     2320     2320              
============================================
  Files           861      861              
  Lines        103573   103573              
  Branches       2412     2412              
============================================
- Hits          19467    19465       -2     
- Misses        82758    82760       +2     
  Partials       1348     1348              
Flag Coverage Δ
editoast 67.96% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first contribution! 🎉
Can you fixup your commits together?


Some guidelines to follow:

  • ✅ Try to have atomic commits (each commit should add something)
  • ❌ No commits that correct commits within the same PR
  • ✅ Make PR as minimalist as possible

Why we require this:

  • Keep our git history as clean as possible and easy to revert
  • Make as simple as possible the review of PR
  • Increases the speed with which a PR will be reviewed and thus merge

@hamz2a hamz2a force-pushed the hai/editoast-bump-dependencies branch from 973d43a to f67891f Compare October 27, 2023 08:16
@hamz2a hamz2a requested a review from flomonster October 27, 2023 08:17
Copy link
Contributor

@Castavo Castavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • There are three new missing closing PR in your description: checkout this
  • Can you clean up your commit message (You squashed your commits instead of fix up)
  • Some dependencies have recently been bump (serde, serde_derive, serde_yaml, futures, tempfile)
    • utoipa as a new major version with breaking changes. We can bump it later with the required fixes.

editoast/Cargo.toml Outdated Show resolved Hide resolved
@flomonster flomonster requested a review from Castavo October 27, 2023 08:48
@hamz2a hamz2a force-pushed the hai/editoast-bump-dependencies branch from f67891f to c11a6ef Compare October 27, 2023 09:29
@hamz2a hamz2a requested a review from flomonster October 27, 2023 09:38
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hamz2a hamz2a added this pull request to the merge queue Oct 27, 2023
Merged via the queue into dev with commit 91712c8 Oct 27, 2023
@hamz2a hamz2a deleted the hai/editoast-bump-dependencies branch October 27, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump editoast dependencies
3 participants