Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: fix translation panto to pantographe #5586

Merged
merged 4 commits into from
Nov 23, 2023
Merged

front: fix translation panto to pantographe #5586

merged 4 commits into from
Nov 23, 2023

Conversation

RomainValls
Copy link
Contributor

closes #5566

@RomainValls RomainValls requested a review from a team as a code owner November 3, 2023 09:22
SarahBellaha
SarahBellaha approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@SarahBellaha SarahBellaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@codecov Codecov
Copy link

codecov bot commented Nov 3, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c39e699) 19.49% compared to head (93b48e5) 19.53%.
Report is 95 commits behind head on dev.

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #5586      +/-   ##
============================================
+ Coverage     19.49%   19.53%   +0.04%     
  Complexity     2322     2322              
============================================
  Files           878      885       +7     
  Lines        105491   106017     +526     
  Branches       2544     2572      +28     
============================================
+ Hits          20561    20708     +147     
- Misses        83449    83800     +351     
- Partials       1481     1509      +28
Flag Coverage Δ
front 8.33% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

clarani
clarani requested changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh thanks for fixing this bug !! Can you also change the english translation in en/map-key.json ? :)

@RomainValls
Copy link
Contributor Author

Thanks Clara, just modified the english translation !

clarani
clarani approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolaswurtz nicolaswurtz added this pull request to the merge queue Nov 9, 2023
@nicolaswurtz nicolaswurtz removed this pull request from the merge queue due to a manual request Nov 9, 2023
@nicolaswurtz
Copy link
Contributor

It's the right term, no need to change it.

@clarani clarani reopened this Nov 10, 2023
clarani
clarani requested changes Nov 10, 2023
View reviewed changes
front/public/locales/fr/map-key.json Outdated Show resolved Hide resolved
front/public/locales/en/map-key.json Outdated Show resolved Hide resolved
@RomainValls RomainValls requested a review from clarani November 16, 2023 17:08
clarani
clarani approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks :)

@RomainValls RomainValls added this pull request to the merge queue Nov 23, 2023
Merged via the queue into dev with commit ed6a693 Nov 23, 2023
5 checks passed
@RomainValls RomainValls deleted the rvs/front-fix-translation-pantograph branch November 23, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SarahBellaha SarahBellaha SarahBellaha approved these changes

@clarani clarani clarani approved these changes

@nicolaswurtz nicolaswurtz nicolaswurtz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Legend is Baissez Panto instead of Baissez pantographe
4 participants
@RomainValls @nicolaswurtz @clarani @SarahBellaha