Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix punctual object position calculation #5635

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

Akctarus
Copy link
Contributor

@Akctarus Akctarus commented Nov 8, 2023

closes #4246

  • Add the approximateDistanceWithEditoastData function to the PointEditionToolFactory when moving/clicking on the map
  • Add a custom field in the PointEditionLeftPanel schema for the 3 entities (bufferStop, detector and signal)

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 95 lines in your changes are missing coverage. Please review.

Comparison is base (5332a7c) 19.62% compared to head (593df66) 19.61%.

Files Patch % Lines
...cations/editor/tools/pointEdition/tool-factory.tsx 0.00% 40 Missing ⚠️
...tions/editor/tools/pointEdition/CustomPosition.tsx 0.00% 25 Missing and 1 partial ⚠️
...lications/editor/tools/pointEdition/components.tsx 0.00% 18 Missing ⚠️
front/src/applications/editor/tools/utils.ts 0.00% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #5635      +/-   ##
============================================
- Coverage     19.62%   19.61%   -0.01%     
  Complexity     2332     2332              
============================================
  Files           908      909       +1     
  Lines        107865   107920      +55     
  Branches       2626     2627       +1     
============================================
  Hits          21167    21167              
- Misses        85139    85193      +54     
- Partials       1559     1560       +1     
Flag Coverage Δ
front 8.62% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Akctarus Akctarus force-pushed the tmn/fix-object-position-calculation branch from 4874996 to 757cb77 Compare November 9, 2023 15:04
@Akctarus Akctarus force-pushed the tmn/fix-object-position-calculation branch from 757cb77 to 7c7639a Compare November 16, 2023 16:51
@Akctarus Akctarus marked this pull request as ready for review November 16, 2023 22:54
@Akctarus Akctarus requested a review from a team as a code owner November 16, 2023 22:54
@Akctarus Akctarus force-pushed the tmn/fix-object-position-calculation branch 4 times, most recently from bc27d4f to e3d5dd3 Compare November 22, 2023 09:23
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested ! Left 2 small comments ✅

@Akctarus Akctarus force-pushed the tmn/fix-object-position-calculation branch from c31733d to a4287ab Compare November 23, 2023 16:04
@Akctarus Akctarus force-pushed the tmn/fix-object-position-calculation branch from a4287ab to 593df66 Compare November 23, 2023 16:35
@Akctarus Akctarus enabled auto-merge November 23, 2023 16:37
@Akctarus Akctarus added this pull request to the merge queue Nov 23, 2023
Merged via the queue into dev with commit 51516f0 Nov 23, 2023
6 of 7 checks passed
@Akctarus Akctarus deleted the tmn/fix-object-position-calculation branch November 23, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong punctual object position calculation
2 participants