-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: Add minzoom = 5 for all editoast layers that missed a minZoom #5678
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5 is great for tracks but I think we should have a higher value for other layers (what about 8
?)
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #5678 +/- ##
============================================
- Coverage 19.59% 19.59% -0.01%
Complexity 2322 2322
============================================
Files 886 886
Lines 105816 105822 +6
Branches 2573 2573
============================================
Hits 20736 20736
- Misses 83570 83576 +6
Partials 1510 1510
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
76b12d5
to
ed320af
Compare
@flomonster you're right, 8 is moreover a good choice, it's updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
All is said here : #5656 (comment)