Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: Add minzoom = 5 for all editoast layers that missed a minZoom #5678

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

nicolaswurtz
Copy link
Contributor

All is said here : #5656 (comment)

@nicolaswurtz nicolaswurtz added kind:enhancement Improvement of existing features area:front Work on Standard OSRD Interface modules labels Nov 14, 2023
@nicolaswurtz nicolaswurtz requested a review from a team as a code owner November 14, 2023 14:25
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 is great for tracks but I think we should have a higher value for other layers (what about 8 ?)

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (6a77c5c) 19.59% compared to head (ed320af) 19.59%.
Report is 3 commits behind head on dev.

Files Patch % Lines
front/src/common/Map/Layers/Switches.tsx 0.00% 2 Missing ⚠️
front/src/common/Map/Layers/geographiclayers.ts 0.00% 2 Missing ⚠️
front/src/common/Map/Layers/Detectors.tsx 0.00% 1 Missing ⚠️
front/src/common/Map/Layers/OperationalPoints.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #5678      +/-   ##
============================================
- Coverage     19.59%   19.59%   -0.01%     
  Complexity     2322     2322              
============================================
  Files           886      886              
  Lines        105816   105822       +6     
  Branches       2573     2573              
============================================
  Hits          20736    20736              
- Misses        83570    83576       +6     
  Partials       1510     1510              
Flag Coverage Δ
front 8.30% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicolaswurtz nicolaswurtz force-pushed the nwz/add-minzoom-5-maplayers branch from 76b12d5 to ed320af Compare November 14, 2023 14:31
@nicolaswurtz
Copy link
Contributor Author

@flomonster you're right, 8 is moreover a good choice, it's updated

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@nicolaswurtz nicolaswurtz added this pull request to the merge queue Nov 22, 2023
Merged via the queue into dev with commit bdf9d88 Nov 22, 2023
@nicolaswurtz nicolaswurtz deleted the nwz/add-minzoom-5-maplayers branch November 22, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules kind:enhancement Improvement of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants