Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix how the allowance ranges are sorted #5680

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Nov 14, 2023

No description provided.

@eckter eckter requested a review from a team as a code owner November 14, 2023 15:02
@eckter eckter requested a review from multun November 14, 2023 15:02
@eckter eckter linked an issue Nov 14, 2023 that may be closed by this pull request
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (db02439) 19.59% compared to head (d5b271c) 19.59%.
Report is 3 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #5680   +/-   ##
=========================================
  Coverage     19.59%   19.59%           
  Complexity     2322     2322           
=========================================
  Files           886      886           
  Lines        105816   105816           
  Branches       2573     2573           
=========================================
  Hits          20736    20736           
  Misses        83570    83570           
  Partials       1510     1510           
Flag Coverage Δ
core 78.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@multun multun added this pull request to the merge queue Nov 17, 2023
Merged via the queue into dev with commit 650db80 Nov 17, 2023
@multun multun deleted the ech/fix-too-much-time branch November 17, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core: allowances sometimes fail because we "can't go fast enough"
4 participants