Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: have a better error when block has no path #5689

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

Khoyo
Copy link
Contributor

@Khoyo Khoyo commented Nov 15, 2023

Closes #5600.

@Khoyo Khoyo requested a review from a team as a code owner November 15, 2023 08:48
@Khoyo Khoyo requested a review from eckter November 15, 2023 08:48
@Khoyo Khoyo self-assigned this Nov 15, 2023
@Khoyo Khoyo force-pushed the yk/block-no-path-better-error branch from fbc9d8b to 8a04707 Compare November 15, 2023 09:24
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (598b2cb) 19.59% compared to head (8a04707) 19.59%.

Files Patch % Lines
...n/fr/sncf/osrd/sim_infra/impl/BlockInfraBuilder.kt 0.00% 7 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #5689      +/-   ##
============================================
- Coverage     19.59%   19.59%   -0.01%     
  Complexity     2323     2323              
============================================
  Files           886      886              
  Lines        105816   105824       +8     
  Branches       2572     2572              
============================================
+ Hits          20739    20740       +1     
- Misses        83569    83576       +7     
  Partials       1508     1508              
Flag Coverage Δ
core 78.75% <11.11%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Khoyo Khoyo added this pull request to the merge queue Nov 15, 2023
Merged via the queue into dev with commit 8d55deb Nov 15, 2023
@Khoyo Khoyo deleted the yk/block-no-path-better-error branch November 15, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core: unclear error when assertion at BlockInfraBuilder.kt:29 is triggered
2 participants