Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: prevent user from saving multiple times #5696

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Nov 15, 2023

close #5557

@clarani clarani requested a review from a team as a code owner November 15, 2023 15:36
@clarani clarani force-pushed the cni-5557-infra-editor-multiple-save branch from 3085309 to 49402f7 Compare November 15, 2023 15:38
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 101 lines in your changes are missing coverage. Please review.

Comparison is base (ef61485) 19.57% compared to head (832f812) 19.57%.

Files Patch % Lines
...lications/editor/tools/rangeEdition/components.tsx 0.00% 48 Missing ⚠️
...lications/editor/tools/trackEdition/components.tsx 0.00% 24 Missing ⚠️
...ications/editor/tools/switchEdition/components.tsx 0.00% 21 Missing ⚠️
...lications/editor/tools/pointEdition/components.tsx 0.00% 3 Missing ⚠️
...rc/applications/editor/tools/pointEdition/tools.ts 0.00% 3 Missing ⚠️
front/src/common/Loader.tsx 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #5696      +/-   ##
============================================
- Coverage     19.57%   19.57%   -0.01%     
  Complexity     2326     2326              
============================================
  Files           886      886              
  Lines        106100   106110      +10     
  Branches       2576     2576              
============================================
+ Hits          20774    20775       +1     
- Misses        83817    83826       +9     
  Partials       1509     1509              
Flag Coverage Δ
front 8.33% <2.88%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm !

@clarani clarani force-pushed the cni-5557-infra-editor-multiple-save branch from 3eefa84 to 832f812 Compare November 17, 2023 09:44
@clarani clarani enabled auto-merge November 17, 2023 09:44
@clarani clarani added this pull request to the merge queue Nov 17, 2023
Merged via the queue into dev with commit bb7a30b Nov 17, 2023
@clarani clarani deleted the cni-5557-infra-editor-multiple-save branch November 17, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Front: Infra-Editor: Multiple saves allowed.
5 participants