-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: editor - implementing ordered layer #5713
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #5713 +/- ##
============================================
+ Coverage 19.59% 19.61% +0.01%
Complexity 2323 2323
============================================
Files 886 886
Lines 105824 105937 +113
Branches 2572 2572
============================================
+ Hits 20739 20782 +43
- Misses 83577 83647 +70
Partials 1508 1508
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1b4b979
to
112f5a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left one comment, but everything works fine! Nice job 💪
112f5a7
to
fe0ff52
Compare
- adding in the conf a set by entities type - refacto wrapped map to use this new config - refacto GeoJson to use the orderLayer
fe0ff52
to
1aebf40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job ! Tested and everything works perfectly.
Left just one comment
f93656e
to
1aebf40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job, tested ✅
Close #5611 and also the detector issue related to #5650 (now detector layer is always on top the track section one)