Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: editor - implementing ordered layer #5713

Merged
merged 1 commit into from
Nov 17, 2023
Merged

front: editor - implementing ordered layer #5713

merged 1 commit into from
Nov 17, 2023

Conversation

sim51
Copy link
Contributor

@sim51 sim51 commented Nov 16, 2023

Close #5611 and also the detector issue related to #5650 (now detector layer is always on top the track section one)

  • adding in the conf a set by entities type
  • refacto wrapped map to use this new config
  • refacto GeoJson to use the orderLayer

@sim51 sim51 marked this pull request as ready for review November 16, 2023 11:55
@sim51 sim51 requested a review from a team as a code owner November 16, 2023 11:55
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 41 lines in your changes are missing coverage. Please review.

Comparison is base (07ebd6a) 19.59% compared to head (f93656e) 19.61%.
Report is 13 commits behind head on dev.

❗ Current head f93656e differs from pull request most recent head 1aebf40. Consider uploading reports for the commit 1aebf40 to get more accurate results

Files Patch % Lines
front/src/config/layerOrder.ts 0.00% 19 Missing and 1 partial ⚠️
front/src/common/Map/Layers/GeoJSONs.tsx 0.00% 16 Missing ⚠️
front/src/common/Map/WarpedMap/WarpedMap.tsx 0.00% 3 Missing ⚠️
front/src/common/IntervalsDataViz/dataviz.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #5713      +/-   ##
============================================
+ Coverage     19.59%   19.61%   +0.01%     
  Complexity     2323     2323              
============================================
  Files           886      886              
  Lines        105824   105937     +113     
  Branches       2572     2572              
============================================
+ Hits          20739    20782      +43     
- Misses        83577    83647      +70     
  Partials       1508     1508              
Flag Coverage Δ
front 8.34% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SarahBellaha SarahBellaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left one comment, but everything works fine! Nice job 💪

front/src/common/Map/Layers/GeoJSONs.tsx Outdated Show resolved Hide resolved
- adding in the conf a set by entities type
- refacto wrapped map to use this new config
- refacto GeoJson to use the orderLayer
Copy link
Contributor

@SarahBellaha SarahBellaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job ! Tested and everything works perfectly.

Left just one comment

front/src/common/Map/Layers/GeoJSONs.tsx Show resolved Hide resolved
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, tested ✅

front/src/common/Map/Layers/GeoJSONs.tsx Show resolved Hide resolved
@sim51 sim51 added this pull request to the merge queue Nov 17, 2023
Merged via the queue into dev with commit c484ac9 Nov 17, 2023
7 checks passed
@sim51 sim51 deleted the bsi/issue-5611 branch November 17, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: error layer not on top
4 participants